Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dubbo JS Observable Service #398

Merged
merged 8 commits into from
May 18, 2024
Merged

Add Dubbo JS Observable Service #398

merged 8 commits into from
May 18, 2024

Conversation

openlg
Copy link
Contributor

@openlg openlg commented May 16, 2024

Currently supported:

dubbo-node supports customer metrics collection and exposure.
Dubbo fastify supports provider metrics collection and exposure.
Currently only dubbo_provider_requests_total, dubbo_provider_requests_succeed_total, dubbo_provider_requests_failed_total, dubbo_provider_qps_total, dubbo_consumer_requests_total, dubbo_consumer_requests_succeed_total, dubbo_consumer_requests_failed_ are supported. total, dubbo_consumer_qps_total metrics.

Current remaining issues:

dubbo-web does not add customer indicator collection
dubbo-express dubbo-next dubbo-node does not add provider indicator collection
Complete more monitoring indicators
Call chain tracking is not implemented

Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit edf17d1 into apache:dubbo3 May 18, 2024
6 checks passed
@openlg openlg mentioned this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants