refactor: inspect code of netty4 classes. (#10295)

apache · Jul 11, 2022 · 5f35f0d · 5f35f0d
1 parent dea2498
commit 5f35f0d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/...remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyClient.java b/...remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyClient.java
@@ -16,6 +16,7 @@
  */
 package org.apache.dubbo.remoting.transport.netty4;
 
+import io.netty.util.concurrent.EventExecutorGroup;
 import org.apache.dubbo.common.URL;
 import org.apache.dubbo.common.Version;
 import org.apache.dubbo.common.config.ConfigurationUtils;
@@ -68,7 +69,7 @@ public class NettyClient extends AbstractClient {
      */
     private static final GlobalResourceInitializer<EventLoopGroup> EVENT_LOOP_GROUP = new GlobalResourceInitializer<>(() ->
         eventLoopGroup(Constants.DEFAULT_IO_THREADS, "NettyClientWorker"),
-        eventLoopGroup -> eventLoopGroup.shutdownGracefully());
+        EventExecutorGroup::shutdownGracefully);
 
     private Bootstrap bootstrap;
 
@@ -143,10 +144,7 @@ protected void initChannel(SocketChannel ch) throws Exception {
 
     private boolean isFilteredAddress(String host) {
         // filter local address
-        if (StringUtils.isEquals(NetUtils.getLocalHost(), host) || NetUtils.isLocalHost(host)) {
-            return true;
-        }
-        return false;
+        return StringUtils.isEquals(NetUtils.getLocalHost(), host) || NetUtils.isLocalHost(host);
     }
 
     @Override

diff --git a/...remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyServer.java b/...remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyServer.java
@@ -81,7 +81,7 @@ public class NettyServer extends AbstractServer {
     private final int serverShutdownTimeoutMills;
 
     public NettyServer(URL url, ChannelHandler handler) throws RemotingException {
-        // you can customize name and type of client thread pool by THREAD_NAME_KEY and THREADPOOL_KEY in CommonConstants.
+        // you can customize name and type of client thread pool by THREAD_NAME_KEY and THREAD_POOL_KEY in CommonConstants.
         // the handler will be wrapped: MultiMessageHandler->HeartbeatHandler->handler
         super(ExecutorUtil.setThreadName(url, SERVER_THREAD_POOL_NAME), ChannelHandlers.wrap(handler, url));
 

diff --git a/...g-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyServerHandler.java b/...g-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyServerHandler.java
@@ -42,7 +42,7 @@ public class NettyServerHandler extends ChannelDuplexHandler {
      * the cache for alive worker channel.
      * <ip:port, dubbo channel>
      */
-    private final Map<String, Channel> channels = new ConcurrentHashMap<String, Channel>();
+    private final Map<String, Channel> channels = new ConcurrentHashMap<>();
 
     private final URL url;