-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support consistent hash load balance when gerenic invoke #10799
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR will fix #10774 |
Codecov Report
@@ Coverage Diff @@
## 3.1 #10799 +/- ##
============================================
- Coverage 67.06% 64.56% -2.50%
+ Complexity 520 468 -52
============================================
Files 1342 1336 -6
Lines 64627 56957 -7670
Branches 10808 8400 -2408
============================================
- Hits 43341 36775 -6566
+ Misses 17004 16228 -776
+ Partials 4282 3954 -328
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some uts to verify this
Do you mean that I have to do a test and construct a lot of invocations to see if load balancing is really achieved? |
It is enough to check that the parameters have been obtained correctly. |
What is the purpose of the change
Support consistent hash load balance when gerenic invoke
Brief changelog
For generalization calls, the toKey function in org.apache.dubbo.rpc.cluster.loadbalance.ConsistentHashLoadBalance has been changed