Make THREAD_NAME_KEY work #5701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
我们知道可以给Provider的业务处理线程池设置类型和size（见ThreadPool扩展点），在org.apache.dubbo.common.constants.CommonConstants中我们定义了THREADPOOL_KEY、THREAD_NAME_KEY、THREADS_KEY等，但唯独THREAD_NAME_KEY的值threadname在dubbo.xsd中没有设定，我想应该是漏了，导致我们无法给线程池设置想要的名字。所以此PR是为了解决这个问题。
We know that you can set the type and size of the Provider's business processing thread pool (see the ThreadPool extension point). In org.apache.dubbo.common.constants.CommonConstants we define THREADPOOL_KEY, THREAD_NAME_KEY, THREADS_KEY, etc., but only the value of THREAD_NAME_KEY The threadname is not set in dubbo.xsd, I think it should be missed, which prevents us from setting the desired name for the thread pool. So this PR is to solve this problem.