-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(marker): add missing type for symbolOffset, fix symbolOffset & symbolKeepAspect doesn't work in markPoint. #14737
Conversation
…oint. - current callback function logic seems inappropriate, data item should not support callback. refactor needed.
…ffset` and add missing return type `string | number` to `SymbolOffsetCallback`.
Thanks for your contribution! The pull request is marked to be |
Currently, the logic about parsing |
…the common symbol util.
when can publish a new version for this merge ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@PiterYang This PR is set to be in 5.2.0, which should be released in about a month. |
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
ty, waiting new version. |
求问下这个特性什么时候能发布呀? |
When the 5.2.0 will be released? checked everyday for months. :( |
Brief Information
This pull request is in the type of:
What does this PR do?
Enhance #14375
string | number
tosymbolOffset
string | number
toSymbolOffsetCallback
symbolOffset
&symbolKeepAspect
doesn't work inmarkPoint
symbolOffset
type issue inSilderTimelineView
normalizeSymbolSize
&normalizeSymbolOffset
to the common symbol util.Fixed issues
Details
Before: What was the problem?
After: How is it fixed in this PR?
Misc
Related test cases or examples to use the new APIs
NA.
Others
Merging options
Other information