-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: time axis overlapped labels #15583
Conversation
Thanks for your contribution! |
@pissang can you please review this MR and tell me if it's in the right direction? |
@svedova Thanks! This change looks good to me and the result looks great! Perhaps we can limit this hiding overlap strategy to the time axis currently. |
@pissang great idea! I've applied the suggested changes and here's the screenshot that shows the chart is still working as expected: I'm going to ask for another round of review 🙏 |
@pissang Thanks a lot for the second round review! Your help is hugely appreciated. I've submitted another commit with the suggested changes, so now back to you 🏓 |
@pissang applied the changes, thanks for your help 🏓 |
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Brief Information
This pull request is in the type of:
What does this PR do?
This PR fixes the overlapping labels in the Time Axis.
Fixed issues
Details
Misc
Related test cases or examples to use the new APIs
NA.
Others
Merging options
Other information