Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix negetive number or string exist in dimensions array, the correspo… #10346

Merged
merged 3 commits into from
May 5, 2019
Merged

Fix negetive number or string exist in dimensions array, the correspo… #10346

merged 3 commits into from
May 5, 2019

Commits on Apr 23, 2019

  1. Fix negetive number or string exist in dimensions array, the correspo… 

    …nding line won't show (#10343)
    @susiwen8
    susiwen8 committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    e72b603 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2019

  1. Check if dataDims[0] type is number or not

    @susiwen8
    susiwen8 committed May 5, 2019
    Configuration menu
    Copy the full SHA
    2068858 View commit details
    Browse the repository at this point in the history

  2. Tweak the "is string" check. 

    Tweak the "is string" check. Should better be the same as the existing checking.
    @100pah
    100pah authored May 5, 2019
    Configuration menu
    Copy the full SHA
    bc07229 View commit details
    Browse the repository at this point in the history