Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8489 geo.label.formatter is not working #10666

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Conversation

susiwen8
Copy link
Contributor

Fix this issue
#8489

@nihaolfccc
Copy link

这个修复了吗?

@nihaolfccc
Copy link

怎么写的啊 我这急需,大佬帮帮忙。

@susiwen8
Copy link
Contributor Author

susiwen8 commented Jun 13, 2019

@nihaolfccc
For now you can write like this

                label: {
                    emphasis: {
                        show: true,
                        formatter: function (params) {
                            console.log(params)
                            return params.name + '123';
                        }
                    },
                    normal: {
                        show: true,
                        formatter: function (params) {
                            console.log(params)
                            return params.name + '1234';
                        }
                    }
                },

@susiwen8
Copy link
Contributor Author

@nihaolfccc
忽视刚才的回复,那是错误的

@nihaolfccc
Copy link

@nihaolfccc
忽视刚才的回复,那是错误的

额。。。

@nihaolfccc
Copy link

@nihaolfccc
忽视刚才的回复,那是错误的

现在还有什么办法吗?

@susiwen8
Copy link
Contributor Author

@nihaolfccc 最快的方法是改源码,自己build一个

@nihaolfccc
Copy link

@nihaolfccc最快的方法是改源码,自己建一个

regions 刚刚找到 这个可以对特定的区域进行操作 好像可以写一个对象进行匹配然后进行操作 谢谢你了大佬

@pissang
Copy link
Contributor

pissang commented Sep 10, 2019

Thanks @susiwen8 . Sorry about the very late review. The fix looks good to me

@pissang pissang merged commit 081f24a into apache:master Sep 10, 2019
@susiwen8 susiwen8 deleted the #8489 branch December 30, 2019 03:26
plainheart added a commit to plainheart/echarts that referenced this pull request Jun 6, 2020
pissang added a commit that referenced this pull request Jun 22, 2020
fix(geo): label formatter in geo works incorrectly, tweaks #10666 & #8612.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants