fix(map): map transform changed from geo coord to screen position; fix #11055 #11272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pissang
reviewed
Sep 18, 2019
src/component/helper/MapDraw.js
Outdated
| points: geometry.exterior | ||
| points: zrUtil.map(geometry.exterior, function (point) { | ||
| return transformPoint(point); | ||
| }) |
There was a problem hiding this comment.
Use naive for loop may have better performance. Especially on the large GeoJSON.
Ovilia
changed the title
This comment has been minimized.
This comment has been minimized.
pissang
previously approved these changes
Sep 19, 2019
pissang
approved these changes
Sep 20, 2019
|
|
Ovilia
added a commit
that referenced
this pull request
Sep 24, 2019
Ovilia
added a commit
that referenced
this pull request
Sep 24, 2019
earo-Lau
pushed a commit
to earo-Lau/incubator-echarts
that referenced
this pull request
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The map transform has been changed from geo coordinate into screen position.
It solves the SVG shadow bug with #11055.
It computes the transform so that the path with map data is in screen coordinate rather than geo coordinate in the rendering stage.
Before: the path positions are in the geo coordinate.
After: the path positions are in the screen coordinate.