fix(12146): drag map into view once roamed away

[KrzysztofMadejski]

Brief Information

This pull request is in the type of:

• [ x ] bug fixing
• new feature
• others

What does this PR do?

Map can be dragged into the view once roamed away. I branched off v4.9.0 tag so it could be fixed within 4.9.0 pipeline still. I haven't seen a branch for v4 development.

Fixed issues

This solves #12146

Details

Before: What was the problem?

see #12146
for explanation and video.

After: How is it fixed in this PR?

Check if mousedown even falls into map rect box is removed. All events within canvas are handled.

Usage

Are there any API changes?

• The API has been changed. -> NO

Related test cases or examples to use the new APIs

I added map-drag-out-and-in.html visual test case. As it is my first PR I'm not sure if I done it right.

I'm also not sure if I didn't break anything, but unit tests are passing.

Others

Merging options

• Please squash the commits into a single one when merge.

Other information

[echarts-bot]

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

[KrzysztofMadejski]

Question: should I also update dist folder? I was expecting that dist is built before publishing, not kept in the repo.

[susiwen8]

@KrzysztofMadejski thanks for contributing in Apache ECharts!

First, you should use TypeScript since we have migrate to TS since 5.0.

Second, Do not submit dist folder, only source code.

[KrzysztofMadejski]

Then I think you should not version dist folder in the repo. I believe it should only be built while publishing to npm.

Second: where should I use ts? I just removed one line, not added anything.

[pissang]

@KrzysztofMadejski Hi, thanks for the contribution.

We don't maintain multiple release branches, v4.x won't have new versions. The fix should always be based on the latest code in the master branch.

About the dist folder. It's common for developers to get the distribution file of the latest stable version on GitHub. Also, CDN like cdnjs will fetch the distribution from this folder. It will only be built and committed before each stable release.

[KrzysztofMadejski]

Oh, that's very sad to hear you do not support old versions.

BTW: You can use Github Releases to serve "compiled" versions: https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/managing-releases-in-a-repository

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. We are sorry for this but 2 years is a long time and the code base has been changed a lot. Thanks for your contribution anyway.

[KrzysztofMadejski]

closing as I'm not working anymore with echarts