-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bar): add startValue
option to specify where the bars start
#17078
Conversation
Thanks for your contribution! Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the |
|
Sure, it's done. |
This looks to be a useful feature, only that more test cases are required. For example, to test the cases when min or max values are defined for the axis, or when And you need to run the visual tests to test the differences caused by this PR. npm run test:visual Choose the latest nightly build to compare with the one build from your source code. |
@Ovilia Extra testcases are added and all visual tests are passed. |
It seems there are a lot of commits that are already in the |
Please also add a |
Now the changes are more naturally co-op with original code and can be applied in dataZoom.
@olivia Good intuition on |
@jiawulin001 Merging is blocked, |
To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: This message is shown because the PR description doesn't contain the document related template. |
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
startValue
option to specify where the bars start
@@ -81,6 +81,8 @@ export interface BarSeriesOption | |||
|
|||
showBackground?: boolean | |||
|
|||
startValue?: number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This option is unused here and should be removed in the next version.
Brief Information
This pull request is in the type of:
What does this PR do?
barSeries.startValue is added for users to specify where the bars start.
Fixed issues
Details
Before: What was the problem?
As stated in the issues. Users cannot specify the start value of bars.
After: How is it fixed in this PR?
Users now can specify
barSeries.startValue
to set the starting value of bars. Stack and multi-axes are also tested to be running correctly.Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
bar-startValue.html
Others
Merging options
Other information