Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update pre commit permission #18813

Merged
merged 1 commit into from
Jun 27, 2023
Merged

chore: update pre commit permission #18813

merged 1 commit into from
Jun 27, 2023

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Jun 27, 2023

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Update the permission of pre-commit husky.

Fixed issues

Details

Before: What was the problem?

$ git cm -m 'xxx'
hint: The '.husky/pre-commit' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.

After: How does it behave after the fixing?

'.husky/pre-commit' can run before commit.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Jun 27, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@plainheart plainheart merged commit b0c8338 into master Jun 27, 2023
@echarts-bot
Copy link

echarts-bot bot commented Jun 27, 2023

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart deleted the husky branch June 27, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants