Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clipping in custom series off by 1 pixel #20041

Conversation

fandi-1205
Copy link
Contributor

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

#19993 Clipping in custom series off by 1 pixel

Fixed issues

Details

Before: What was the problem?

There is a boundary overflow issue when creating a clipping path in the custom series.
image

After: How does it behave after the fixing?

Modified part of the logic for the clipping path. Since the custom type does not include the lineStyle property, the thickness of the axis line cannot be correctly obtained. It is necessary to obtain the thickness of the axis lines before adjusting the position and size of the clipping path.
Changing the thickness of the axis lines will not cause overflow.
image
image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Jun 18, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

@fandi-1205 fandi-1205 closed this Jun 18, 2024
@fandi-1205 fandi-1205 deleted the fix-clipping-in-custom-series-off-by-pixel branch June 18, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: awaiting doc Document changes is required for this PR. PR: first-time contributor size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant