[ISSUE #428]Fix Chinese annotation #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to the Apache EventMesh (incubating) community!!
This is your first PR in our project. We're very excited to have you onboard contributing. Your contributions are greatly appreciated!
Please make sure that the changes are covered by tests.
We will be here shortly.
Let us know if you need any help!
Want to get closer to the community?
WeChat Group：
Mailing Lists:
| Name | Description | Subscribe | Unsubscribe | Archive |
|---|---|---|---|---|
| Users | User support and questions mailing list | Subscribe | Unsubscribe | Mail Archives |
| Development | Development related discussions | Subscribe | Unsubscribe | Mail Archives |
| Commits | All commits to repositories | Subscribe | Unsubscribe | Mail Archives |
xwm1992
requested changes
Jul 12, 2021
...c/main/java/org/apache/eventmesh/common/protocol/http/body/client/HeartbeatResponseBody.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/eventmesh/common/protocol/http/body/message/ReplyMessageResponseBody.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/eventmesh/common/protocol/http/body/message/ReplyMessageResponseBody.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/eventmesh/common/protocol/http/body/message/SendMessageBatchResponseBody.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/eventmesh/common/protocol/http/body/message/SendMessageBatchResponseBody.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/eventmesh/common/protocol/http/body/message/SendMessageBatchResponseBody.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/eventmesh/common/protocol/http/body/message/SendMessageBatchResponseBody.java
Outdated
Show resolved
Hide resolved
...a/org/apache/eventmesh/common/protocol/http/body/message/SendMessageBatchV2ResponseBody.java
Outdated
Show resolved
Hide resolved
...a/org/apache/eventmesh/common/protocol/http/body/message/SendMessageBatchV2ResponseBody.java
Outdated
Show resolved
Hide resolved
5 tasks
qqeasonchen
changed the title
MajorHe1
approved these changes
Jul 14, 2021
ruanwenjun
reviewed
Jul 14, 2021
| @@ -21,6 +21,7 @@ | |||
|
|
|||
| /** | |||
| * 这个RETRY的意思是 客户端发现投递的消息它没有监听时, 告诉EventMesh 发往下一个, 重试几次以实现灰度 , 预留 | |||
There was a problem hiding this comment.
We may also need to remove this Chinese comment
ruanwenjun
reviewed
Jul 14, 2021
...tmesh-common/src/main/java/org/apache/eventmesh/common/protocol/http/common/ProtocolKey.java
Show resolved
Hide resolved
This was referenced Jul 15, 2021
xwm1992
approved these changes
Jul 16, 2021
jjz921024
pushed a commit
to jjz921024/incubator-eventmesh
that referenced
this pull request
Jul 25, 2021
* The Chinese in the notes is translated into English. * Translation improvement * Translation improvement * fix Chinese annotation on runtime module
xwm1992
pushed a commit
to xwm1992/EventMesh
that referenced
this pull request
Dec 27, 2021
* The Chinese in the notes is translated into English. * Translation improvement * Translation improvement * fix Chinese annotation on runtime module
xwm1992
pushed a commit
that referenced
this pull request
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translate the Chinese to English on the common module.
Only the Chinese part of the notes has been translated, and the Chinese in the code has not changed.