Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4136] change the null reference to empty object in UrlMappingPattern.java #4846

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

heliang666s
Copy link

@heliang666s heliang666s commented Apr 17, 2024

Motivation

change the null reference to empty object in UrlMappingPattern.java Fixes #4136

Modifications

change return null to a empty map

Documentation

No

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the Apache EventMesh (incubating) community!!
This is your first PR in our project. We're very excited to have you onboard contributing. Your contributions are greatly appreciated!

Please make sure that the changes are covered by tests.
We will be here shortly.
Let us know if you need any help!

Want to get closer to the community?

WeChat Group:
wechat_qr

Mailing Lists:

Name Description Subscribe Unsubscribe Archive
Users User support and questions mailing list Subscribe Unsubscribe Mail Archives
Development Development related discussions Subscribe Unsubscribe Mail Archives
Commits All commits to repositories Subscribe Unsubscribe Mail Archives

mxsm
mxsm previously approved these changes Apr 17, 2024
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Welcome to EventMesh community

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heliang666s The code is all right, please repair the CI. You can synchronize the eventmesh project in your own repository to the master branch, then pull a branch for development based on the master branch, and finally submit the PR to merge into the master branch of Eventmesh.

@Pil0tXia
Copy link
Member

Pil0tXia commented Apr 17, 2024

@heliang666s

The target branch you merge this PR into should be master instead of develop. By then you should be able to pass CI.

Developing with a branch that corresponds to a single issue minimizes the chance that you'll run into any Git difficulties.

By the way, kindly refer to the standard title format used in other PRs.

@mxsm How about delete this outdated develop branch?

@Pil0tXia Pil0tXia changed the base branch from develop to master April 17, 2024 15:04
@Pil0tXia Pil0tXia dismissed mxsm’s stale review April 17, 2024 15:04

The base branch was changed.

@Pil0tXia
Copy link
Member

@heliang666s Please resolve conflicts.

@mxsm The The base branch was changed. comment was a automatic message sent by GitHub.

@xwm1992 xwm1992 changed the title change the null reference to empty object in UrlMappingPattern.java [ISSUE #4136]change the null reference to empty object in UrlMappingPattern.java Apr 22, 2024
@xwm1992 xwm1992 changed the title [ISSUE #4136]change the null reference to empty object in UrlMappingPattern.java [ISSUE #4136] change the null reference to empty object in UrlMappingPattern.java Apr 22, 2024
@Pil0tXia
Copy link
Member

Hi @heliang666s , the eventmesh-admin-rocketmq module referenced in this issue has been removed in #4490 (merged on 2023-10-17). Do you have any additional information to share? Feel free to share your latest insights with us. If you feel that this issue has been resolved, you are welcome to close it. We sincerely appreciate your contributions to Apache EventMesh and you can pick another Good First Issue to start your first step.

Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added the Stale label Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] change the null reference to empty object in UrlMappingPattern.java
3 participants