Issue #405 Fix SubscriptionType typo error #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merged from upstream
…ice, CountDownLatch and PreDestroy hook
# Conflicts: # eventmesh-test/src/main/java/org/apache/eventmesh/http/demo/sub/service/SubService.java
…ice, CountDownLatch and PreDestroy hook
Codecov Report
@@ Coverage Diff @@
## develop #522 +/- ##
==========================================
Coverage 10.42% 10.42%
Complexity 328 328
==========================================
Files 241 241
Lines 11737 11737
Branches 1001 1001
==========================================
Hits 1224 1224
Misses 10411 10411
Partials 102 102
Continue to review full report at Codecov.
|
xwm1992
approved these changes
Sep 15, 2021
|
LGTM |
xwm1992
pushed a commit
to xwm1992/EventMesh
that referenced
this pull request
Dec 27, 2021
* [Issue apache#337] Fix HttpSubscriber startup issue * [Issue apache#337] test commit * [Issue apache#337] revert test commit * [Issue apache#337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook * [Issue apache#337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook * [Issue apache#337] Address code review comment for Subscriber Demo App * Fix subscriptionType typo Co-authored-by: j00441484 <jin.rong.luo@huawei.com>
xwm1992
pushed a commit
that referenced
this pull request
Aug 4, 2022
* [Issue #337] Fix HttpSubscriber startup issue * [Issue #337] test commit * [Issue #337] revert test commit * [Issue #337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook * [Issue #337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook * [Issue #337] Address code review comment for Subscriber Demo App * Fix subscriptionType typo Co-authored-by: j00441484 <jin.rong.luo@huawei.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ISSUE#405
Motivation
Fix SubscriptionType field typo error in SubscriptionItem Class
Modifications
Describe the modifications you've done.
Documentation