This repository has been archived by the owner on Apr 4, 2021. It is now read-only.
FALCON-2113 Falcon retry happens in few cases inspite of a manual kill from the user. move it to a different state(ignore) and check for that state before retrying to stop it from retrying. #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll from the user. move it to a different state(ignore) and check for that state before retrying to stop it from retrying.
sandeepSamudrala
changed the title
sandeepSamudrala
changed the title
sandeepSamudrala
changed the title
| @@ -111,7 +114,8 @@ public abstract InstancesResult getInstanceParams(Entity entity, Date start, Dat | |||
|
|
|||
| public abstract boolean isNotificationEnabled(String cluster, String jobID) throws FalconException; | |||
|
|
|||
| public abstract Boolean isWorkflowKilledByUser(String cluster, String jobId) throws FalconException; | |||
| public abstract Boolean isWorkflowKilledByUser(String cluster, String jobId, | |||
| String parentId) throws FalconException; | |||
There was a problem hiding this comment.
Adding a parent Id here makes some assumptions on the hierarchy (coord->wf) which does not hold for native workflow engine. Instead, do a WorkflowInfo to retrieve the parent inside the method.
…hod to check for manual kill
|
+1 |
|
Rebased the patch and fixed failures. |
|
+1 |
pallavi-rao
pushed a commit
to pallavi-rao/falcon
that referenced
this pull request
Feb 16, 2018
…l from the user. move it to a different state(ignore) and check for that state before retrying to stop it from retrying. Author: sandeep <sandysmdl@gmail.com> Reviewers: @pallavi-rao, @PraveenAdlakha Closes apache#265 from sandeepSamudrala/FALCON-2113 and squashes the following commits: 2a00bef [sandeep] fixing failures 285c796 [sandeep] Merge branch 'master' of https://github.com/apache/falcon into FALCON-2113 4f585a1 [sandeep] Incorporated review comments. Removed parent Id from passing into method to check for manual kill 2d0d9a3 [sandeep] FALCON-2113. Falcon retry happens in few cases inspite of a manual kill from the user. move it to a different state(ignore) and check for that state before retrying to stop it from retrying. 1bb8d3c [sandeep] Merge branch 'master' of https://github.com/apache/falcon c065566 [sandeep] reverting last line changes made 1a4dcd2 [sandeep] rebased and resolved the conflicts from master 271318b [sandeep] FALCON-2097. Adding UT to the new method for getting next instance time with Delay. a94d4fe [sandeep] rebasing from master 9e68a57 [sandeep] FALCON-298. Feed update with replication delay creates holes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.