This repository has been archived by the owner on Apr 4, 2021. It is now read-only.
FALCON-2175 java.lang.IllegalArgumentException in LogMover service #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 24, 2016 22:57
… JIRA type" This reverts commit a6d8c6c.
| if (StringUtils.isBlank(engineUrl)) { | ||
| LOG.warn("Unable to retrieve workflow url for {} with status {} ", | ||
| context.getWorkflowId(), context.getWorkflowStatus()); | ||
| return 0; |
There was a problem hiding this comment.
there could be a case where the oozie host has been moved from when the instance ran and the current running oozie.
In which case this will not work. Should we not try with the current oozie url? to get the status of the workflow id?
There was a problem hiding this comment.
If the host has moved, the log movement anyway can't happen as the new host cannot return the old logs.
There was a problem hiding this comment.
makes sense. Got you.
sandeepSamudrala
approved these changes
Oct 26, 2016
|
looks good +1 |
pallavi-rao
pushed a commit
to pallavi-rao/falcon
that referenced
this pull request
Feb 16, 2018
Author: Pallavi Rao <pallavi.rao@inmobi.com> Reviewers: @sandeepSamudrala, @praveen8927 Closes apache#292 from pallavi-rao/2175 and squashes the following commits: 38e16ee [Pallavi Rao] Fixing checkstyle issue 144c588 [Pallavi Rao] Revert "FALCON-1821 Update git pull merge script to accept and update JIRA type" 3848b10 [Pallavi Rao] FALCON-2175 java.lang.IllegalArgumentException in LogMover service 5ecb344 [Pallavi Rao] FALCON-2175 java.lang.IllegalArgumentException in LogMover service be17164 [Pallavi Rao] Merge remote-tracking branch 'upstream/master' a6d8c6c [Pallavi Rao] FALCON-1821 Update git pull merge script to accept and update JIRA type
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.