-
Notifications
You must be signed in to change notification settings - Fork 112
FALCON-2175 java.lang.IllegalArgumentException in LogMover service #292
Conversation
… JIRA type" This reverts commit a6d8c6c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for that 1 comment. looks good.
if (StringUtils.isBlank(engineUrl)) { | ||
LOG.warn("Unable to retrieve workflow url for {} with status {} ", | ||
context.getWorkflowId(), context.getWorkflowStatus()); | ||
return 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there could be a case where the oozie host has been moved from when the instance ran and the current running oozie.
In which case this will not work. Should we not try with the current oozie url? to get the status of the workflow id?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the host has moved, the log movement anyway can't happen as the new host cannot return the old logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense. Got you.
looks good +1 |
Author: Pallavi Rao <pallavi.rao@inmobi.com> Reviewers: @sandeepSamudrala, @praveen8927 Closes apache#292 from pallavi-rao/2175 and squashes the following commits: 38e16ee [Pallavi Rao] Fixing checkstyle issue 144c588 [Pallavi Rao] Revert "FALCON-1821 Update git pull merge script to accept and update JIRA type" 3848b10 [Pallavi Rao] FALCON-2175 java.lang.IllegalArgumentException in LogMover service 5ecb344 [Pallavi Rao] FALCON-2175 java.lang.IllegalArgumentException in LogMover service be17164 [Pallavi Rao] Merge remote-tracking branch 'upstream/master' a6d8c6c [Pallavi Rao] FALCON-1821 Update git pull merge script to accept and update JIRA type
No description provided.