Skip to content
This repository has been archived by the owner on Apr 4, 2021. It is now read-only.

FALCON-1611: Falcon Admin Commands #53

Closed
wants to merge 45 commits into from
Closed

Conversation

prongs
Copy link
Contributor

@prongs prongs commented Feb 29, 2016

No description provided.

@prongs prongs changed the title Falcon Admin Commands FALCON-1611: Falcon Admin Commands Feb 29, 2016
}

@CliCommand(value = {ADMIN_COMMAND_PREFIX + VERSION_OPT}, help = VERSION_OPT_DESCRIPTION)
public String version(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename it to clientVersion to help clarify that this doesn't reflect server version but only the client version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is server version. This sends a rest api call to determine version from server.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming the command to server version

@ajayyadava
Copy link
Contributor

@prongs Can you please rebase this pull request? Sorry for the churn, will take it up on priority once you rebase.

@prongs
Copy link
Contributor Author

prongs commented Aug 3, 2016

Closing in favor of #249

@prongs prongs closed this Aug 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants