-
Notifications
You must be signed in to change notification settings - Fork 112
Conversation
} | ||
|
||
@CliCommand(value = {ADMIN_COMMAND_PREFIX + VERSION_OPT}, help = VERSION_OPT_DESCRIPTION) | ||
public String version( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename it to clientVersion to help clarify that this doesn't reflect server version but only the client version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is server version. This sends a rest api call to determine version from server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renaming the command to server version
@prongs Can you please rebase this pull request? Sorry for the churn, will take it up on priority once you rebase. |
Closing in favor of #249 |
No description provided.