Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FELIX-6066] Prevent duplicate activation of ConfigurationManager #185

Closed
wants to merge 1 commit into from
Closed

[FELIX-6066] Prevent duplicate activation of ConfigurationManager #185

wants to merge 1 commit into from

Conversation

grgrzybek
Copy link

No description provided.

cziegeler
cziegeler reviewed Feb 21, 2019
View reviewed changes
Copy link
Contributor

@cziegeler cziegeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, looks good to me. What about moving the call to setActivated into the activate() method?

@grgrzybek
Copy link
Author

sure - it's after all not a setter. I updated the PR.

@asfgit asfgit closed this in 6568668 Mar 7, 2019
asfgit pushed a commit that referenced this pull request Nov 6, 2019
@jbonofre
[FELIX-6066] This closes #185
05ab8dd 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1854973 13f79535-47bb-0310-9956-ffa450edef68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cziegeler cziegeler cziegeler left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grgrzybek @cziegeler