Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mysql] fix deserialization issue on table metadata binlog event #2682

Merged
merged 9 commits into from
Dec 5, 2023

Conversation

qidian99
Copy link
Contributor

close #2680

@maver1ck
Copy link
Contributor

Maybe we should create issue in original repo ?

@leonardBang
Copy link
Contributor

Maybe we should create issue in original repo ?

+1, @qidian99 would you like to file an issue in upstream repo?

@leonardBang
Copy link
Contributor

@ruanhang1993 Would you like to help review this issue when you have time ?

@leonardBang leonardBang self-requested a review November 30, 2023 15:52
@leonardBang leonardBang requested review from ruanhang1993 and removed request for ruanhang1993 December 1, 2023 02:13
import java.util.logging.Level;
import java.util.logging.Logger;

/** Copied from mysql-binlog-connector 0.25.3 to fix table metadata deserialization issue. */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some description about changes and raise an issue in mysql-binlog-connector linked here.

Copy link
Contributor

@ruanhang1993 ruanhang1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ruanhang1993 ruanhang1993 merged commit f970444 into apache:master Dec 5, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] mysql-cdc 2.5-SNAPSHOT, failed to deserialize table metadata event for full_types table
4 participants