[FLINK-32222] avoid using non-public DataInputDeserializer and DataOutputSerializer. Remove overkill ThreadLocal cache. Update archunit violations #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echauchot
changed the title
…tputSerializer. Remove overkill ThreadLocal cache. Update archunit violations
echauchot
force-pushed
the
FLINK-31806-avoid-non-public-api-usage
branch
from
2fe21af
to
c2d7dc3
Compare
|
closing this PR because ticket number is incorrect. For jira ticket linking, re-submitting the same PR with correct ticket number as renaming does not update the PR link in jira. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to this PR:
Removed non public classes usages except Preconditions, VisibleForTesting and ClosureCleaner for which violations are added here. I updated violations store in advance of the merge of the above PR that fixes the Connector rule.
Removed overkill ThreadLocal cache as the other similar connectors, don't cache Streams for Split serialization. This allows simpler and more standard serialization code.
@zentol PTAL ?