Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-29436] Spotless 2.27.1 already supports JDK 17 #19

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

tisonkun
Copy link
Member

This is a subtask of FLINK-29436.

I'm using JDK17 and I found this task skipped when developing the pulsar connector.

Since the block is already fixed at apache/flink#20911, we can do the same here and release a 1.0.1 or 1.1.0.

cc @zentol

Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun requested a review from zentol July 18, 2023 10:41
Copy link
Contributor

@zentol zentol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1, see the comment in the bit that you're deleting.

@zentol
Copy link
Contributor

zentol commented Jul 18, 2023

wait...

@zentol
Copy link
Contributor

zentol commented Jul 18, 2023

Why are you upgrading the plugin? In apache/flink#20911 2..27.1 works on Java 17?

@zentol
Copy link
Contributor

zentol commented Jul 18, 2023

(It would be great if we the plugin versions were reasonably in sync across repos)

@tisonkun
Copy link
Member Author

Why are you upgrading the plugin? In apache/flink#20911 2..27.1 works on Java 17?

Yes. 2.27.1 should work, while I know at lease diffplug/spotless@f9f1f30 I made a good supplement to develop experience.

Since the later version should be compatible with previous ones, is there some reason preventing using a latest version?

@zentol zentol self-assigned this Jul 18, 2023
@tisonkun
Copy link
Member Author

(It would be great if we the plugin versions were reasonably in sync across repos)

Sounds reasonable. Would you suggest we pin on 2.27.1 for now. Or simultaneously update the one in the main repo?

@zentol
Copy link
Contributor

zentol commented Jul 18, 2023

is there some reason preventing using a latest version?

Every version bump, be it a plugin or dependency, bears risks. It may behave differently, there may be a bug, there may be a vulnerability due to added features. Hence one should have a good reason for updating anything.

simultaneously update the one in the main repo?

If we upgrade it then it should be done as a separate ticket.

I know at lease diffplug/spotless@f9f1f30 I made a good supplement to develop experience.

Are you aware of the fast profile that skips the spotless plugin (among others)?

@tisonkun
Copy link
Member Author

If we upgrade it then it should be done as a separate ticket.

OK. Let me go back to 2.27.1 then.

pom.xml Outdated Show resolved Hide resolved
@tisonkun tisonkun changed the title [FLINK-29436] Upgrade spotless to support JDK 17 [FLINK-29436] Spotless 2.27.1 already supports JDK 17 Jul 18, 2023
@tisonkun
Copy link
Member Author

Updated.

@zentol zentol merged commit 813ab45 into parent_pom Jul 20, 2023
4 checks passed
@tisonkun tisonkun deleted the spotless-jdk17 branch July 20, 2023 14:59
@tisonkun
Copy link
Member Author

@zentol do we have an estimate for the 1.1.0 release? I can help to prepare the artifacts and drive the vote. But perhaps with a guide of what artifacts should be included. It seems we don't have these code on https://dist.apache.org/ but simply release to the Nexus repository?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants