-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-29436] Spotless 2.27.1 already supports JDK 17 #19
Conversation
Signed-off-by: tison <wander4096@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-1, see the comment in the bit that you're deleting.
wait... |
Why are you upgrading the plugin? In apache/flink#20911 2..27.1 works on Java 17? |
(It would be great if we the plugin versions were reasonably in sync across repos) |
Yes. 2.27.1 should work, while I know at lease diffplug/spotless@f9f1f30 I made a good supplement to develop experience. Since the later version should be compatible with previous ones, is there some reason preventing using a latest version? |
Sounds reasonable. Would you suggest we pin on 2.27.1 for now. Or simultaneously update the one in the main repo? |
Every version bump, be it a plugin or dependency, bears risks. It may behave differently, there may be a bug, there may be a vulnerability due to added features. Hence one should have a good reason for updating anything.
If we upgrade it then it should be done as a separate ticket.
Are you aware of the |
OK. Let me go back to 2.27.1 then. |
Updated. |
@zentol do we have an estimate for the 1.1.0 release? I can help to prepare the artifacts and drive the vote. But perhaps with a guide of what artifacts should be included. It seems we don't have these code on https://dist.apache.org/ but simply release to the Nexus repository? |
This is a subtask of FLINK-29436.
I'm using JDK17 and I found this task skipped when developing the pulsar connector.
Since the block is already fixed at apache/flink#20911, we can do the same here and release a 1.0.1 or 1.1.0.
cc @zentol