[FLINK-16928] Remove requirement for legacy scheduler #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igalshilman
approved these changes
May 15, 2020
There was a problem hiding this comment.
LGTM!
fyi #108 was approved, and you can merge the recent PRs
tzulitai
added a commit
that referenced
this pull request
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #111, which upgrades the Flink version to 1.10.1.
After upgrading Flink to 1.10.1, https://issues.apache.org/jira/browse/FLINK-16927 will be resolved and therefore allowing us to no longer require the use of the legacy scheduler.
This PR removes the requirement and removes the configuration from all
flink-confs and docs.Verifying
I suggest waiting until #108 is merged, and rebase this PR on top of that to verify that the new scheduler is indeed working for failure recovery with the newly introduced E2E there.