[FLINK-15198][Deployment / Mesos] remove mesos.resourcemanager.tasks.mem #10890

PengTaoWW · 2020-01-17T16:29:07Z

fix https://issues.apache.org/jira/projects/FLINK/issues/FLINK-15198

What is the purpose of the change

In FLINK-15082, we deprecated 'mesos.resourcemanager.tasks.mem' in favour of the new unified option 'taskmanager.memory.total-process.size' from FLIP-49. We should remove it now in 1.11.
https://issues.apache.org/jira/projects/FLINK/issues/FLINK-15198?filter=allopenissues

Brief change log

modified the code and deleted the part that used 'mesos.resourcemanager.tasks.mem' in the code

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not documented)

flinkbot · 2020-01-17T16:31:44Z

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 1587714 (Fri Feb 28 21:49:11 UTC 2020)

✅no warnings

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

❓ 1. The [description] looks good.
❓ 2. There is [consensus] that the contribution should go into to Flink.
❓ 3. Needs [attention] from.
❓ 4. The change fits into the overall [architecture].
❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
@flinkbot approve all to approve all aspects
@flinkbot approve-until architecture to approve everything until architecture
@flinkbot attention @username1 [@username2 ..] to require somebody's attention
@flinkbot disapprove architecture to remove an approval you gave earlier

flinkbot · 2020-01-17T17:04:13Z

CI report:

1c28ae3 UNKNOWN
f5282a9 Travis: SUCCESS Azure: SUCCESS
1587714 Travis: PENDING

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot run travis re-run the last Travis build
@flinkbot run azure re-run the last Azure build

KarmaGYZ

Thanks for the contribution @PengTaoWW . However, I think you could not just change the key to the MESOS_RM_TASKS_MEMORY_MB. You need to provide another solution.

KarmaGYZ · 2020-01-19T08:20:03Z

...rc/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java

@@ -64,7 +64,7 @@
 	 */
 	@Deprecated
 	public static final ConfigOption<Integer> MESOS_RM_TASKS_MEMORY_MB =
-		key("mesos.resourcemanager.tasks.mem")
+		key("taskmanager.memory.total-process.size")


I think we could not simply change the key.

from https://github.com/apache/flink/pull/10513/files#r356585015, just need to delete the code and comments that use MEMOS_RM_TASKS_MEMORY_MB?

PengTaoWW · 2020-01-19T15:22:48Z

@KarmaGYZ I modified the code and deleted the part that used 'mesos.resourcemanager.tasks.mem' in the code。

PengTaoWW · 2020-01-19T16:39:53Z

@flinkbot run travis

KarmaGYZ · 2020-01-21T02:29:21Z

flink-jepsen/src/jepsen/flink/db.clj

@@ -303,7 +303,7 @@
    "-Djobmanager.rpc.address=$(hostname -f)"
    "-Djobmanager.rpc.port=6123"
    "-Dmesos.resourcemanager.tasks.cpus=1"
-    "-Dmesos.resourcemanager.tasks.mem=2048" ;; FLINK-15082: this option must be set instead of taskmanager.memory.process.size
+    "-Dtaskmanager.memory.process.size=2048m" ;; FLINK-15082: this option must be set instead of taskmanager.memory.process.size


I guess this note could be removed after this PR.

Let me fix it

KarmaGYZ · 2020-01-21T02:44:23Z

...rc/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java

-		if (configuration.contains(MESOS_RM_TASKS_MEMORY_MB) &&
-			configuration.contains(TaskManagerOptions.TOTAL_PROCESS_MEMORY) &&
-			!legacyTotalProcessMemory.equals(unifiedTotalProcessMemory)) {
+		if (!configuration.contains(TaskManagerOptions.TOTAL_PROCESS_MEMORY)) {


I'm not sure that the total process memory should be explicitly set here. According to the FLIP-49 Doc. User need either of these three options configured:

Task Heap Memory and Managed Memory

Total Flink Memory

Total Process Memory

After this PR, I think we could directly construct the TaskExecutorResourceSpec from the flinkConfig. @azagrebin Please correct me if I have any misunderstanding.

Indeed, we do not need this method getTotalProcessMemory anymore.
TaskExecutorProcessUtils will parse the options in createContaineredTaskManagerParameters.
Subsequently, we do not need .withTotalProcessMemory(totalProcessMemory) in createContaineredTaskManagerParameters.

I will remove .withTotalProcessMemory (totalProcessMemory) in createContaineredTaskManagerParameters and delete the getTotalProcessMemory method

@azagrebin Already modified

PengTaoWW · 2020-01-22T08:20:14Z

@flinkbot run travis

PengTaoWW · 2020-01-23T01:36:46Z

@flinkbot run travis

azagrebin · 2020-02-25T09:54:15Z

@PengTaoWW
We usually use git rebase on master instead of merge to fetch changes from master into PR.
I have done this for now, squashed the commits and force-pushed it into your branch.
Just for note, you will have to remove your branch locally and checkout it again from the updated remote one to work on this further.

azagrebin

Thanks for the contribution @ptmagic !
I agree with @KarmaGYZ on his comment and added more thoughts there.
This comment has to be addressed before merging.
Otherwise, it looks good.

azagrebin · 2020-02-25T10:09:56Z

...rc/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java

-		if (configuration.contains(MESOS_RM_TASKS_MEMORY_MB) &&
-			configuration.contains(TaskManagerOptions.TOTAL_PROCESS_MEMORY) &&
-			!legacyTotalProcessMemory.equals(unifiedTotalProcessMemory)) {
+		if (!configuration.contains(TaskManagerOptions.TOTAL_PROCESS_MEMORY)) {


Indeed, we do not need this method getTotalProcessMemory anymore.
TaskExecutorProcessUtils will parse the options in createContaineredTaskManagerParameters.
Subsequently, we do not need .withTotalProcessMemory(totalProcessMemory) in createContaineredTaskManagerParameters.

PengTaoWW · 2020-02-26T07:16:09Z

@flinkbot run travis

fix https://issues.apache.org/jira/projects/FLINK/issues/FLINK-15198 Delete getTotalProcessMemory remove .withTotalProcessMemory (totalProcessMemory) in createContaineredTaskManagerParameters and delete the getTotalProcessMemory method

PengTaoWW · 2020-02-26T11:57:01Z

@flinkbot run travis

azagrebin

Thanks for addressing the comments @PengTaoWW , LGTM
I also pushed a small migration doc fix

KarmaGYZ

Thanks for the update. @PengTaoWW . It generally LGTM. Just two minor comments.

KarmaGYZ · 2020-02-27T09:55:45Z

docs/ops/memory/mem_migration.md

@@ -134,7 +134,7 @@ but they still have the same semantics for the job manager process. See also [ho
 The previous options which were responsible for the total memory used by Flink are `taskmanager.heap.size` or `taskmanager.heap.mb`.
 Despite their naming, they included not only JVM heap but also other off-heap memory components. The options have been deprecated.

-The Mesos integration also had a separate option with the same semantics: `mesos.resourcemanager.tasks.mem` which has also been deprecated.


Should we just remove this line?

As it is a migration guide from Flink <= 1.9, the option always was in Flink <= 1.9, so I think it is still worth mentioning it here.

Agreed. +1 to merge this PR.

KarmaGYZ · 2020-02-27T09:56:02Z

docs/ops/memory/mem_migration.zh.md

@@ -134,7 +134,7 @@ but they still have the same semantics for the job manager process. See also [ho
 The previous options which were responsible for the total memory used by Flink are `taskmanager.heap.size` or `taskmanager.heap.mb`.
 Despite their naming, they included not only JVM heap but also other off-heap memory components. The options have been deprecated.

-The Mesos integration also had a separate option with the same semantics: `mesos.resourcemanager.tasks.mem` which has also been deprecated.
+The Mesos integration also had a separate option with the same semantics: `mesos.resourcemanager.tasks.mem` which has also been removed.


ptmagic · 2020-02-27T11:08:57Z

Thank you for your help, I will continue to contribute

rmetzger added the review=description? label Jan 17, 2020

PengTaoWW requested review from azagrebin and tillrohrmann January 17, 2020 16:35

rmetzger added the component=Deployment/Mesos label Jan 17, 2020

KarmaGYZ requested changes Jan 19, 2020

View reviewed changes

KarmaGYZ requested changes Jan 21, 2020

View reviewed changes

PengTaoWW force-pushed the removeMesosResourceManagerTasksMem branch from fbce565 to 0ec632d Compare January 22, 2020 07:54

azagrebin force-pushed the removeMesosResourceManagerTasksMem branch from f683466 to 7c3dadd Compare February 25, 2020 09:50

azagrebin requested changes Feb 25, 2020

View reviewed changes

PengTaoWW force-pushed the removeMesosResourceManagerTasksMem branch from 1c28ae3 to f5282a9 Compare February 26, 2020 11:55

migration doc fix

1587714

azagrebin approved these changes Feb 27, 2020

View reviewed changes

KarmaGYZ reviewed Feb 27, 2020

View reviewed changes

azagrebin closed this in a8bb211 Feb 27, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FLINK-15198][Deployment / Mesos] remove mesos.resourcemanager.tasks.mem #10890

[FLINK-15198][Deployment / Mesos] remove mesos.resourcemanager.tasks.mem #10890

PengTaoWW commented Jan 17, 2020 •

edited

Loading

flinkbot commented Jan 17, 2020 •

edited

Loading

flinkbot commented Jan 17, 2020 •

edited

Loading

KarmaGYZ left a comment

KarmaGYZ Jan 19, 2020

PengTaoWW Jan 19, 2020

PengTaoWW commented Jan 19, 2020

PengTaoWW commented Jan 19, 2020

KarmaGYZ Jan 21, 2020

PengTaoWW Jan 21, 2020

KarmaGYZ Jan 21, 2020

azagrebin Feb 25, 2020

PengTaoWW Feb 25, 2020

PengTaoWW Feb 26, 2020

PengTaoWW commented Jan 22, 2020

PengTaoWW commented Jan 23, 2020

azagrebin commented Feb 25, 2020

azagrebin left a comment

azagrebin Feb 25, 2020

PengTaoWW commented Feb 26, 2020

PengTaoWW commented Feb 26, 2020

azagrebin left a comment

KarmaGYZ left a comment

KarmaGYZ Feb 27, 2020

azagrebin Feb 27, 2020

KarmaGYZ Feb 27, 2020

KarmaGYZ Feb 27, 2020

ptmagic commented Feb 27, 2020

[FLINK-15198][Deployment / Mesos] remove mesos.resourcemanager.tasks.mem #10890

[FLINK-15198][Deployment / Mesos] remove mesos.resourcemanager.tasks.mem #10890

Conversation

PengTaoWW commented Jan 17, 2020 • edited Loading

What is the purpose of the change

Brief change log

Verifying this change

Does this pull request potentially affect one of the following parts:

Documentation

flinkbot commented Jan 17, 2020 • edited Loading

Automated Checks

Review Progress

flinkbot commented Jan 17, 2020 • edited Loading

CI report:

KarmaGYZ left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PengTaoWW commented Jan 19, 2020

PengTaoWW commented Jan 19, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PengTaoWW commented Jan 22, 2020

PengTaoWW commented Jan 23, 2020

azagrebin commented Feb 25, 2020

azagrebin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PengTaoWW commented Feb 26, 2020

PengTaoWW commented Feb 26, 2020

azagrebin left a comment

Choose a reason for hiding this comment

KarmaGYZ left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ptmagic commented Feb 27, 2020

PengTaoWW commented Jan 17, 2020 •

edited

Loading

flinkbot commented Jan 17, 2020 •

edited

Loading

flinkbot commented Jan 17, 2020 •

edited

Loading