-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-16400][fs] Fixing e2e tests that directly use Hadoop fs. #11312
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 59080ec (Wed Mar 04 15:44:21 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
@StephanEwen , I did the rough thing and removed |
/** | ||
* Gets a description of the characteristics of this file system. | ||
*/ | ||
public abstract FileSystemKind getKind(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The FileSystem
class is a @Public
API, meaning that no methods may be removed.
If we cannot remove the method ( |
Also removing invalid HdfsKindTest cases.
There is still a test failure on azure (e2e) but it seems to be unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'm adding a one extra comment explaining why method is deprecated (it's not used anymore) and will merge in a minute.
What is the purpose of the change
Fixes two different kinds of errors caused by FLINK-16015, which disables direct access to Hadoop fs if we offer a plugin.
Brief change log
Verifying this change
Fixes existing tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation