Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-16586][network] Build ResultSubpartitionInfo and InputChannelInfo in respective constructors #11400

Merged
merged 2 commits into from
Mar 18, 2020

Conversation

zhijiangW
Copy link
Contributor

What is the purpose of the change

In the constructors of ResultSubpartition and InputChannel, the respective ResultSubpartitionInfo and InputChannelInfo should be created as well.

These infos would be used for interacting with ChannelStateReader and ChannelStateWriter future.

Brief change log

  • Build InputChannelInfo in constructor of InputChannel
  • Build ResultSubpartitionInfo in constructor of ResultSubpartition

Verifying this change

  • Added ResultPartitionTest#testResultSubpartitionInfo and SingleInputGateTest#testInputChannelInfo

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 2ca2fa8 (Fri Mar 13 08:25:11 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 13, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@zhijiangW
Copy link
Contributor Author

Thanks for the review @rkhachatryan !
I fixed the check style issue and commented for ResultPartitionBuilder issue. If you are not insistent on it, I would prefer keeping it as now. :)

Copy link
Contributor

@rkhachatryan rkhachatryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @zhijiangW .
LGTM except for a couple of changes highlighted.

@zhijiangW zhijiangW force-pushed the FLINK-16586 branch 2 times, most recently from 5057598 to ea3d768 Compare March 16, 2020 04:14
…nfo in respective constructors

In the constructors of ResultSubpartition and InputChannel, the respective ResultSubpartitionInfo and InputChannelInfo should be created as well.
These infos would be used for interacting with ChannelStateReader and ChannelStateWriter future.

This cloese apache#11400.
@zhijiangW zhijiangW merged commit ddec073 into apache:master Mar 18, 2020
zhijiangW added a commit that referenced this pull request Mar 18, 2020
…nfo in respective constructors

In the constructors of ResultSubpartition and InputChannel, the respective ResultSubpartitionInfo and InputChannelInfo should be created as well.
These infos would be used for interacting with ChannelStateReader and ChannelStateWriter future.

This cloese #11400.
liuzhixing1006 pushed a commit to liuzhixing1006/flink that referenced this pull request Mar 19, 2020
…nfo in respective constructors

In the constructors of ResultSubpartition and InputChannel, the respective ResultSubpartitionInfo and InputChannelInfo should be created as well.
These infos would be used for interacting with ChannelStateReader and ChannelStateWriter future.

This cloese apache#11400.
liuzhixing1006 pushed a commit to liuzhixing1006/flink that referenced this pull request Mar 19, 2020
@zhijiangW zhijiangW deleted the FLINK-16586 branch June 10, 2020 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants