-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-16586][network] Build ResultSubpartitionInfo and InputChannelInfo in respective constructors #11400
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 2ca2fa8 (Fri Mar 13 08:25:11 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
...rc/test/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGateTest.java
Outdated
Show resolved
Hide resolved
...time/src/test/java/org/apache/flink/runtime/io/network/partition/ResultPartitionBuilder.java
Show resolved
Hide resolved
Thanks for the review @rkhachatryan ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @zhijiangW .
LGTM except for a couple of changes highlighted.
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NettyShuffleEnvironment.java
Show resolved
Hide resolved
5057598
to
ea3d768
Compare
…nfo in respective constructors In the constructors of ResultSubpartition and InputChannel, the respective ResultSubpartitionInfo and InputChannelInfo should be created as well. These infos would be used for interacting with ChannelStateReader and ChannelStateWriter future. This cloese apache#11400.
…nfo in respective constructors In the constructors of ResultSubpartition and InputChannel, the respective ResultSubpartitionInfo and InputChannelInfo should be created as well. These infos would be used for interacting with ChannelStateReader and ChannelStateWriter future. This cloese #11400.
…nfo in respective constructors In the constructors of ResultSubpartition and InputChannel, the respective ResultSubpartitionInfo and InputChannelInfo should be created as well. These infos would be used for interacting with ChannelStateReader and ChannelStateWriter future. This cloese apache#11400.
What is the purpose of the change
In the constructors of
ResultSubpartition
andInputChannel
, the respectiveResultSubpartitionInfo
andInputChannelInfo
should be created as well.These infos would be used for interacting with
ChannelStateReader
andChannelStateWriter
future.Brief change log
InputChannelInfo
in constructor ofInputChannel
ResultSubpartitionInfo
in constructor ofResultSubpartition
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation