[FLINK-16535][table] rename BatchTableSink#emitDataSet to BatchTableSink#consumeDataSet, and return DataSink #11657
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
*To solve buffer problem,
BatchTableEnvironment
should generate Plan based onDataSink
s. However, BatchTableSink#emitDataSet returns void now. So this pr aim to solve this: renameBatchTableSink#emitDataSet
toBatchTableSink#consumeDataSet
(aligns withStreamTableSink#consumeDataStream
) and returnDataSink
. This is an incompatible change *Brief change log
Verifying this change
This change is already covered by existing tests, such as org.apache.flink.table.catalog.CatalogTableITCase, org.apache.flink.table.api.TableEnvironmentITCase, etc..
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation