-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-17230] Fix incorrect returned address of Endpoint for external Service of ClusterIP type #12277
Conversation
… external Service of ClusterIP type
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 689aafe (Fri Oct 16 10:54:39 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
cc @tisonkun. Could you help take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. LGTM. +1 for merging.
… Service of ClusterIP type This closes apache#12277 .
… Service of ClusterIP type This closes #12277 .
… Service of ClusterIP type This closes apache#12277 .
What is the purpose of the change
At the moment, when external Service is set to ClusterIP, we return
${internal-service-name} + "." + nameSpace
as the address of the Endpoint, which could be problematic since we don't create the internal service in ZooKeeper based HA setups. According to FLINK-16602, we always use external Service for rest communication so that this PR returns${external-service-name} + "." + nameSpace
as Endpoint's address instead.Brief change log
Verifying this change
This change hardens
Fabric8FlinkKubeClientTest#testClusterIPService
to add a test branch for Endpoint's address.Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation