Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-18063][checkpointing] Fix the race condition for aborting current checkpoint in CheckpointBarrierUnaligner #12511

Merged
merged 4 commits into from
Jun 9, 2020

Conversation

zhijiangW
Copy link
Contributor

@zhijiangW zhijiangW commented Jun 7, 2020

What is the purpose of the change

There are three aborting scenarios which might encounter race condition:

1. CheckpointBarrierUnaligner#processCancellationBarrier
2. CheckpointBarrierUnaligner#processEndOfPartition
3. AlternatingCheckpointBarrierHandler#processBarrier

They only consider the pending checkpoint triggered by #processBarrier from task thread to abort it. Actually the checkpoint might also be triggered by #notifyBarrierReceived from netty thread in race condition, so we should also handle properly to abort it.

Brief change log

  • Fix the process of AlternatingCheckpointBarrierHandler#processBarrier
  • Fix the process of CheckpointBarrierUnaligner#processEndOfPartition to abort checkpoint properly
  • Fix the process of CheckpointBarrierUnaligner#processCancellationBarrier to abort checkpoint properly

Verifying this change

  • Added new unit test CheckpointBarrierUnalignerTest#testProcessCancellationBarrierAfterNotifyBarrierReceived
  • Added new unit test CheckpointBarrierUnalignerTest#testProcessCancellationBarrierAfterProcessBarrier
  • Added new unit test CheckpointBarrierUnalignerTest#testProcessCancellationBarrierBeforeProcessAndReceiveBarrier

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 7, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 72fc053 (Sun Jun 07 14:09:43 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 7, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

…d method in CheckpointBarrierHandler

Simplify the implementations of CheckpointBarrierTracker and CheckpointBarrierUnaligner to reuse the parent default implementation.

This closes apache#12460.
…atingCheckpointBarrierHandler#getAlignmentDurationNanos

We should take the value from active handler instead of aligned handler, because aligned handler is only used for savepoint and in
most cases the unaligned alignment duration should always be 0.

This cloese apache#12460.
@zhijiangW zhijiangW force-pushed the FLINK-18063-master branch 3 times, most recently from 4e9a8fe to 6778e65 Compare June 9, 2020 04:34
…point in CheckpointBarrierUnaligner

There are three aborting scenarios which might encounter race condition:

1. CheckpointBarrierUnaligner#processCancellationBarrier
2. CheckpointBarrierUnaligner#processEndOfPartition
3. AlternatingCheckpointBarrierHandler#processBarrier

They only consider the pending checkpoint triggered by #processBarrier from task thread to abort it. Actually the checkpoint might
also be triggered by #notifyBarrierReceived from netty thread in race condition, so we should also handle properly to abort it.

This closes apache#12460.
@zhijiangW
Copy link
Contributor Author

Cherry-pick it to master from #12406 which was reviewed and approved before.
The failure e2e is known StreamingKafkaITCase, so ignore it to merge.

@zhijiangW zhijiangW merged commit f672ae5 into apache:master Jun 9, 2020
@zhijiangW zhijiangW deleted the FLINK-18063-master branch June 10, 2020 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants