-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-18832][datastream] Add compatible check for blocking partition with buffer timeout #13209
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 92b731b (Thu Aug 20 15:32:56 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
16693da
to
454310e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @zhijiangW
Please see my comments below.
...-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphGenerator.java
Outdated
Show resolved
Hide resolved
...ming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
Outdated
Show resolved
Hide resolved
...-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java
Outdated
Show resolved
Hide resolved
1133139
to
5c5e70c
Compare
@rkhachatryan , thanks for reviews and I updated the codes for addressing some problems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the PR @zhijiangW
LGTM in general (approving).
I commented on some nits.
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamEdge.java
Outdated
Show resolved
Hide resolved
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamEdge.java
Show resolved
Hide resolved
...-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphGenerator.java
Outdated
Show resolved
Hide resolved
...ming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
Outdated
Show resolved
Hide resolved
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamEdge.java
Outdated
Show resolved
Hide resolved
...-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java
Show resolved
Hide resolved
5c5e70c
to
fd8b1df
Compare
… with buffer timeout From the requirement it is no need to enable buffer timeout for batch jobs since the downstream can only consume data when the upstream finishes. Furthermore the current implementation of BoundedBlockingSubpartition does not consider the concurrent issue from the flusher thread by enabling buffer timeout. So it is nice to check this compatibility during job graph generation in advance and give a friendly message hint for users. This closes apache#13209.
fd8b1df
to
e1fe913
Compare
e1fe913
to
d41657d
Compare
… with buffer timeout From the requirement it is no need to enable buffer timeout for batch jobs since the downstream can only consume data when the upstream finishes. Furthermore the current implementation of BoundedBlockingSubpartition does not consider the concurrent issue from the flusher thread by enabling buffer timeout. So it is nice to check this compatibility during job graph generation in advance and give a friendly message hint for users. This closes apache#13209.
… with buffer timeout From the requirement it is no need to enable buffer timeout for batch jobs since the downstream can only consume data when the upstream finishes. Furthermore the current implementation of BoundedBlockingSubpartition does not consider the concurrent issue from the flusher thread by enabling buffer timeout. So it is nice to check this compatibility during job graph generation in advance and give a friendly message hint for users. This closes apache#13209.
d41657d
to
79b151e
Compare
… with buffer timeout From the requirement it is no need to enable buffer timeout for batch jobs since the downstream can only consume data when the upstream finishes. Furthermore the current implementation of BoundedBlockingSubpartition does not consider the concurrent issue from the flusher thread by enabling buffer timeout. So it is nice to check this compatibility during job graph generation in advance and give a friendly message hint for users. This closes apache#13209.
79b151e
to
873283f
Compare
… with buffer timeout From the requirement it is no need to enable buffer timeout for batch jobs since the downstream can only consume data when the upstream finishes. Furthermore the current implementation of BoundedBlockingSubpartition does not consider the concurrent issue from the flusher thread by enabling buffer timeout. So it is nice to check this compatibility during job graph generation in advance and give a friendly message hint for users. This closes apache#13209.
… with buffer timeout From the requirement it is no need to enable buffer timeout for batch jobs since the downstream can only consume data when the upstream finishes. Furthermore the current implementation of BoundedBlockingSubpartition does not consider the concurrent issue from the flusher thread by enabling buffer timeout. So it is nice to check this compatibility during job graph generation in advance and give a friendly message hint for users. This closes apache#13209.
… with buffer timeout From the requirement it is no need to enable buffer timeout for batch jobs since the downstream can only consume data when the upstream finishes. Furthermore the current implementation of BoundedBlockingSubpartition does not consider the concurrent issue from the flusher thread by enabling buffer timeout. So it is nice to check this compatibility during job graph generation in advance and give a friendly message hint for users. This closes apache#13209.
… with buffer timeout From the requirement it is no need to enable buffer timeout for batch jobs since the downstream can only consume data when the upstream finishes. Furthermore the current implementation of BoundedBlockingSubpartition does not consider the concurrent issue from the flusher thread by enabling buffer timeout. So it is nice to check this compatibility during job graph generation in advance and give a friendly message hint for users. This closes apache#13209.
… with buffer timeout From the requirement it is no need to enable buffer timeout for batch jobs since the downstream can only consume data when the upstream finishes. Furthermore the current implementation of BoundedBlockingSubpartition does not consider the concurrent issue from the flusher thread by enabling buffer timeout. So it is nice to check this compatibility during job graph generation in advance and give a friendly message hint for users. This closes #13209.
… with buffer timeout From the requirement it is no need to enable buffer timeout for batch jobs since the downstream can only consume data when the upstream finishes. Furthermore the current implementation of BoundedBlockingSubpartition does not consider the concurrent issue from the flusher thread by enabling buffer timeout. So it is nice to check this compatibility during job graph generation in advance and give a friendly message hint for users. This closes #13209.
What is the purpose of the change
The current BoundedBlockingSubpartition in runtime does not support positive flush timeout setting by design based on the current scheduler strategy. So it is nice to check this compatibility during job graph generation and give some helpful messages for guiding users, which can avoid potential concurrent issues in runtime stack.
Brief change log
Verifying this change
Add new
testNormalShuffleModeWithBufferTimeout
andtestConflictShuffleModeWithBufferTimeout
for verifying the effect.Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation