-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-21163][python] Fix the issue that Python dependencies specified via CLI override the dependencies specified in configuration #14774
Conversation
…d via CLI override the dependencies specified in configuration
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 1e2a1f5 (Wed Jan 27 11:31:33 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dianfu Thanks for your PR! In this PR the high priority python file configurations are placed in front of the lower priority python file configurations, so I think we should place the python files added via TableEnvironment#add_python_file
and StreamExecutionEnvironment#add_python_file
in front of others because they have the highest priority in our design.
@WeiZhong94 Thanks a lot for the view. Updated the PR. |
@dianfu Thanks for your update. LGTM, +1 to merge. |
…d via CLI override the dependencies specified in configuration This closes #14774.
What is the purpose of the change
*This pull request fix the issue that Python dependencies specified via CLI override the dependencies specified in configuration. It will merge the cli option
-pyfs
with the configurationpython.files
and merge the cli optionpyarch
with the configurationpython.archives
*Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation