Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-21163][python] Fix the issue that Python dependencies specified via CLI override the dependencies specified in configuration #14774

Closed
wants to merge 4 commits into from

Conversation

dianfu
Copy link
Contributor

@dianfu dianfu commented Jan 27, 2021

What is the purpose of the change

*This pull request fix the issue that Python dependencies specified via CLI override the dependencies specified in configuration. It will merge the cli option -pyfs with the configuration python.files and merge the cli option pyarch with the configuration python.archives *

Verifying this change

This change added tests and can be verified as follows:

  • Added test PythonDependencyUtilsTest#testPythonDependencyConfigMerge

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

…d via CLI override the dependencies specified in configuration
@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 1e2a1f5 (Wed Jan 27 11:31:33 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 27, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@WeiZhong94 WeiZhong94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dianfu Thanks for your PR! In this PR the high priority python file configurations are placed in front of the lower priority python file configurations, so I think we should place the python files added via TableEnvironment#add_python_file and StreamExecutionEnvironment#add_python_file in front of others because they have the highest priority in our design.

@dianfu
Copy link
Contributor Author

dianfu commented Jan 28, 2021

@WeiZhong94 Thanks a lot for the view. Updated the PR.

@WeiZhong94
Copy link
Contributor

@dianfu Thanks for your update. LGTM, +1 to merge.

@dianfu dianfu closed this in 4104608 Jan 29, 2021
dianfu added a commit that referenced this pull request Jan 29, 2021
…d via CLI override the dependencies specified in configuration

This closes #14774.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants