-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-21172][canal][json] canal-json format include es field #14792
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit c7bea18 (Fri May 28 08:15:53 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
@wuchong , the CI result is successful. If you are available, please help to review this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SteNicholas . I only left a single minor comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What is the purpose of the change
Metadata column of
CanalJsonDecodingFormat
doesn't support to extract thees
field of Canal JSON record, which field extracts from MySQL binlog represent for the row data real change time in MySQL. Theevent-timestamp
metadata column expresses the event time.Brief change log
CanalJsonDecodingFormat
addsevent-timestamp
metadata column for thees
field of Canal JSON record.Verifying this change
CanalJsonSerDeSchemaTest
adds the validation to verify whether theevent-timestamp
metadata column value is equal to the value ofes
field.KafkaChangelogTableITCase
adds theevent-timestamp
metadata column in the DDL of Kafka source table to verify theevent-timestamp
metadata column could be used as event time.Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation