Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-21268]Fix scrolling issue in Firefox #14848

Closed
wants to merge 1 commit into from
Closed

[FLINK-21268]Fix scrolling issue in Firefox #14848

wants to merge 1 commit into from

Conversation

lovelock
Copy link

@lovelock lovelock commented Feb 3, 2021

What is the purpose of the change

  1. Fix scrolling bug in Firefox. Logs view both in TaskManager and JobManager can't scroll with mouse in Firefox because of the bug in monaco-editor of version 0.16.0, which is mentioned here
  2. npm install would fail on installing @ant-design/icons-angular-icons however the package can only be installed via ng add @ant-design/icons-angular and so the package.json and package-lock.json is updated in the process.

Brief change log

  1. Upgrade monaco-editor from ^0.16.0 to ^0.18.0. The current version of monaco-editor is 0.22.3, but it won't compile.
  2. Add dependency of ant-design/icons-angular to make the compiling happy

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 3, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 598b598 (Wed Feb 03 09:44:20 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • Invalid pull request title: No valid Jira ID provided

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 3, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@lovelock lovelock changed the title Fix scrolling issue in Firefox [FLINK-21268]Fix scrolling issue in Firefox Feb 4, 2021
@pnowojski
Copy link
Contributor

@flinkbot run azure

@zentol
Copy link
Contributor

zentol commented Feb 11, 2021

@vthinkxie Could you take a look?

@vthinkxie
Copy link
Contributor

Hi @lovelock
@ant-design/icons-angular is the dependency of ng-zorro-antd, which should be installed automatically.
can you check your npm version via run npm version?

@lovelock

This comment has been minimized.

@lovelock
Copy link
Author

lovelock commented Feb 15, 2021

Hi @lovelock
@ant-design/icons-angular is the dependency of ng-zorro-antd, which should be installed automatically.
can you check your npm version via run npm version?

Maybe you can ignore this PR and just upgrade monaco-editor from ^0.16.0 to ^0.18.0 and then test with Firefox to check if the scrolling issue is gone.

@lovelock

This comment has been minimized.

@lovelock

This comment has been minimized.

@lovelock
Copy link
Author

I've hidden 3 abused comments by myself because all the errors I run into are because network problem. However git-commit-id-plugin would cause OOM error because of network problem is somewhat confusing.

@lovelock
Copy link
Author

Hi @lovelock
@ant-design/icons-angular is the dependency of ng-zorro-antd, which should be installed automatically.
can you check your npm version via run npm version?

I've noticed the differences between two package-lock.json due to lockFileVersion so I would change node version and try it later.

@lovelock
Copy link
Author

@vthinkxie please see this #14960

@lovelock lovelock closed this Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants