-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-21268]Fix scrolling issue in Firefox #14848
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 598b598 (Wed Feb 03 09:44:20 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
@flinkbot run azure |
@vthinkxie Could you take a look? |
Hi @lovelock |
This comment has been minimized.
This comment has been minimized.
Maybe you can ignore this PR and just upgrade monaco-editor from ^0.16.0 to ^0.18.0 and then test with Firefox to check if the scrolling issue is gone. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I've hidden 3 abused comments by myself because all the errors I run into are because network problem. However |
I've noticed the differences between two |
@vthinkxie please see this #14960 |
What is the purpose of the change
npm install
would fail on installing@ant-design/icons-angular-icons
however the package can only be installed viang add @ant-design/icons-angular
and so the package.json and package-lock.json is updated in the process.Brief change log
^0.16.0
to^0.18.0
. The current version of monaco-editor is 0.22.3, but it won't compile.ant-design/icons-angular
to make the compiling happyVerifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: no