-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-22619][python] Drop usages of BatchTableEnvironment and old planner in Python #16008
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 881ebf0 (Sat Aug 28 12:13:01 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
CC @dianfu @HuangXingBo |
@twalthr Thanks a lot for the work. I will take a look asap. |
Hi @twalthr I have pushed two commits about reverting some python tests and removing python serializers used in old planner. |
Thanks for the additional commits @HuangXingBo. I'm fine to merge this PR now once the build turns green. Are you also giving your ok or are we expecting another review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What is the purpose of the change
This is a major cleanup of the Python module that drops support for
BatchTableEnvironment
and old planner.Some tests might need to be reintroduced in followup issues. We might need several cleanup iterations to make the API clean and concise again. Also the documentation.
Brief change log
Removes usages of:
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: yesDocumentation