Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-22619][python] Drop usages of BatchTableEnvironment and old planner in Python #16008

Closed
wants to merge 3 commits into from

Conversation

twalthr
Copy link
Contributor

@twalthr twalthr commented May 26, 2021

What is the purpose of the change

This is a major cleanup of the Python module that drops support for BatchTableEnvironment and old planner.

Some tests might need to be reintroduced in followup issues. We might need several cleanup iterations to make the API clean and concise again. Also the documentation.

Brief change log

Removes usages of:

  • DataSet
  • BatchTableEnvironment
  • Legacy planner
  • ExecutionEnvironment

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): yes
  • The public API, i.e., is any changed class annotated with @Public(Evolving): yes
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented May 26, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 881ebf0 (Sat Aug 28 12:13:01 UTC 2021)

Warnings:

  • 1 pom.xml files were touched: Check for build and licensing issues.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@twalthr
Copy link
Contributor Author

twalthr commented May 26, 2021

CC @dianfu @HuangXingBo
I'm sure I forgot something. Feel free to push commits to this pull request if you think some tests should remain in a modified version. My Python deletion skills are better than my Python programming skills ;-) Also the Python shell needs an update as it does not use the unified TableEnvironment yet.

@flinkbot
Copy link
Collaborator

flinkbot commented May 26, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@HuangXingBo
Copy link
Contributor

@twalthr Thanks a lot for the work. I will take a look asap.

@HuangXingBo
Copy link
Contributor

Hi @twalthr I have pushed two commits about reverting some python tests and removing python serializers used in old planner.

@twalthr
Copy link
Contributor Author

twalthr commented May 28, 2021

Thanks for the additional commits @HuangXingBo. I'm fine to merge this PR now once the build turns green. Are you also giving your ok or are we expecting another review?

Copy link
Contributor

@HuangXingBo HuangXingBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@twalthr twalthr closed this in a2afa88 May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants