-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-22844]Add doc to introduce ExplainDetails for EXPLAIN sytnax #16051
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit c4831e9 (Wed Jun 02 07:22:54 UTC 2021) ✅no warnings Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chaozwn for the contribution, the content looks good, I left some syntax comments.
@@ -30,6 +30,7 @@ under the License. | |||
|
|||
EXPLAIN statements are used to explain the logical and optimized query plans of a query or an INSERT statement. | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert the unnecessary change
{{< top >}} | ||
|
||
## ExplainDetails | ||
```sql |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The quoted content is not SQL
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useless
``` | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useless
{{< top >}} | ||
|
||
## ExplainDetails | ||
```text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as above
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as above
@chaozwn Thanks for the update, but when we resolve reviewer's comment, we should append commit rather than squashing and force pushing which we cannot know the comment is fixed or not, because the squash way can not compare with previous comment and reviewer have to review again. |
I'm very sorry about do this.The reason why I use force push is because the latest version of flink is too big, and I need to re-merge a large number of branches in the code, and this may cause the display of this branch to be abnormal. |
in next time, I will choose rebase master carefully |
Yes, rebasing master is recommended, and it doesn't matter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chaozwn Sorry for the late response, I left minor comments, Could you also update your commit message which should be [FLINK-22844]
?
Flink SQL> CREATE TABLE MyTable1 (`count` bigint, word VARCHAR(256)) WITH ('connector' = 'datagen'); | ||
[INFO] Table has been created. | ||
|
||
Flink SQL> CREATE TABLE MyTable2 (`count` bigint, word VARCHAR(256); | ||
Flink SQL> CREATE TABLE MyTable2 (`count` bigint, word VARCHAR(256)) WITH ('connector' = 'datagen'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change, could you also add connector option for other languages?
|
||
{{< tabs "explain result" >}} | ||
|
||
{{< tab "PLAN FOR" >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{{< tab "PLAN FOR" >}} | |
{{< tab "EXPLAIN PLAN" >}} |
|
||
{{< /tab >}} | ||
|
||
{{< tab "EXPLAINDETAILS" >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{{< tab "EXPLAINDETAILS" >}} | |
{{< tab "EXPLAIN PLAN WITH DETAILS" >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have completed the modification.
adapt explain detail new function, add description how to use explain details.
adapt explain detail new function, add description how to use explain details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for he update @chaozwn , LGTM
Merging... |
…ils for EXPLAIN sytnax (apache#16051)
What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
Brief change log
(for example:)
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation