Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-22910][runtime] Refine ShuffleMaster lifecycle management for pluggable shuffle service framework #16465

Closed
wants to merge 4 commits into from

Conversation

wsry
Copy link
Contributor

@wsry wsry commented Jul 12, 2021

What is the purpose of the change

This PR refines ShuffleMaster lifecycle management for pluggable shuffle service framework which includes:

  1. [FLINK-23214][runtime] Make ShuffleMaster a cluster level shared service;
  2. [FLINK-22674][runtime] Provide JobID when applying for shuffle resources by ShuffleMaster#registerPartitionWithProducer;
  3. [FLINK-23249][runtime] Introduce ShuffleMasterContext to ShuffleMaster;
  4. [FLINK-22910][runtime] Add lifecycle methods to ShuffleMaster including open, close, registerJob and unregisterJob.

Brief change log

  • Make ShuffleMaster a cluster level shared service;
  • Provide JobID when applying for shuffle resources by ShuffleMaster#registerPartitionWithProducer;
  • Introduce ShuffleMasterContext to ShuffleMaster;
  • Add lifecycle methods to ShuffleMaster including open, close, registerJob and unregisterJob.

Verifying this change

This change is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 12, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 56a034b (Sat Aug 28 13:09:11 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 12, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@wsry wsry force-pushed the FLINK-22910 branch 2 times, most recently from 8730612 to d42a23c Compare July 12, 2021 10:27
@wsry wsry changed the title [Flink 22910][runtime] Refine ShuffleMaster lifecycle management for pluggable shuffle service framework [FLINK-22910][runtime] Refine ShuffleMaster lifecycle management for pluggable shuffle service framework Jul 13, 2021
@wsry wsry force-pushed the FLINK-22910 branch 2 times, most recently from 952176e to 82583fb Compare July 19, 2021 03:21
@wsry wsry force-pushed the FLINK-22910 branch 4 times, most recently from fb3c004 to 16a88a2 Compare July 29, 2021 04:10
@wsry wsry force-pushed the FLINK-22910 branch 2 times, most recently from 41ea8d4 to 6608bdb Compare August 3, 2021 06:29
@wsry
Copy link
Contributor Author

wsry commented Aug 3, 2021

@guoweiM @zhuzhurk Thanks for the review and feedbacks. I have updated the PR accordingly.

Copy link
Contributor

@zhuzhurk zhuzhurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all the comments. @wsry
The change looks good to me.

kevin.cyj added 4 commits August 4, 2021 10:14
This patch makes ShuffleMaster a cluster level shared service, which makes it consistent with the ShuffleEnvironment.
…ces by ShuffleMaster#registerPartitionWithProducer
This patch adds some lifecycle methods to ShuffleMaster including open, close, registerJob and unregisterJob.
@wsry
Copy link
Contributor Author

wsry commented Aug 4, 2021

Rebased master and squashed fixup commits.

Copy link
Contributor

@guoweiM guoweiM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wsry for resolving the comments. LGTM.

@zhuzhurk
Copy link
Contributor

zhuzhurk commented Aug 4, 2021

@flinkbot run azure

@zhuzhurk
Copy link
Contributor

zhuzhurk commented Aug 5, 2021

Merging.

@zhuzhurk zhuzhurk closed this in 80df36b Aug 5, 2021
hhkkxxx133 pushed a commit to hhkkxxx133/flink that referenced this pull request Aug 25, 2021
This patch adds some lifecycle methods to ShuffleMaster including open, close, registerJob and unregisterJob.

This closes apache#16465.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants