-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-22910][runtime] Refine ShuffleMaster lifecycle management for pluggable shuffle service framework #16465
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 56a034b (Sat Aug 28 13:09:11 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
8730612
to
d42a23c
Compare
952176e
to
82583fb
Compare
fb3c004
to
16a88a2
Compare
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterGateway.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/JobShuffleContext.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/JobShuffleContext.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ShuffleMaster.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/test/java/org/apache/flink/runtime/shuffle/ShuffleMasterTest.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/test/java/org/apache/flink/runtime/shuffle/ShuffleMasterTest.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/test/java/org/apache/flink/runtime/shuffle/ShuffleMasterTest.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/test/java/org/apache/flink/runtime/shuffle/ShuffleMasterTest.java
Show resolved
Hide resolved
flink-runtime/src/test/java/org/apache/flink/runtime/shuffle/ShuffleMasterTest.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ShuffleMasterContext.java
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ShuffleMasterContext.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ShuffleMaster.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/JobShuffleContext.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/flink/runtime/dispatcher/JobMasterServiceLeadershipRunnerFactory.java
Outdated
Show resolved
Hide resolved
41ea8d4
to
6608bdb
Compare
...e/src/main/java/org/apache/flink/runtime/io/network/partition/JobMasterPartitionTracker.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing all the comments. @wsry
The change looks good to me.
This patch makes ShuffleMaster a cluster level shared service, which makes it consistent with the ShuffleEnvironment.
…ces by ShuffleMaster#registerPartitionWithProducer
This patch adds some lifecycle methods to ShuffleMaster including open, close, registerJob and unregisterJob.
Rebased master and squashed fixup commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @wsry for resolving the comments. LGTM.
@flinkbot run azure |
Merging. |
This patch adds some lifecycle methods to ShuffleMaster including open, close, registerJob and unregisterJob. This closes apache#16465.
What is the purpose of the change
This PR refines ShuffleMaster lifecycle management for pluggable shuffle service framework which includes:
Brief change log
Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation