[FLINK-23111][runtime-web] Bump angular's and ng-zorro's version to 12 #16603

yangjunhan · 2021-07-27T08:20:24Z

What is the purpose of the change

Step-by-step modernize flink-runtime-web, i.e. Flink UI.

Brief change log

Bump to the latest version of Angular and NG-Zorro.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): yes
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

flinkbot · 2021-07-27T08:23:31Z

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit afabfeb (Tue Jul 27 08:23:31 UTC 2021)

Warnings:

No documentation files were touched! Remember to keep the Flink docs up to date!
This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

❓ 1. The [description] looks good.
❓ 2. There is [consensus] that the contribution should go into to Flink.
❓ 3. Needs [attention] from.
❓ 4. The change fits into the overall [architecture].
❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
@flinkbot approve all to approve all aspects
@flinkbot approve-until architecture to approve everything until architecture
@flinkbot attention @username1 [@username2 ..] to require somebody's attention
@flinkbot disapprove architecture to remove an approval you gave earlier

Airblader

Changes look good to me, thanks!

flinkbot · 2021-07-27T08:59:40Z

CI report:

63a1ff7 Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot run travis re-run the last Travis build
@flinkbot run azure re-run the last Azure build

Airblader · 2021-07-27T20:09:38Z

BTW, I'm also totally fine with doing the upgrades all the way to Angular 12 on the same PR. Just separating by commit to make it easier to review would be appreciated, but we don't need to wait on merges every single time that way.

yangjunhan · 2021-07-28T01:45:05Z

BTW, I'm also totally fine with doing the upgrades all the way to Angular 12 on the same PR. Just separating by commit to make it easier to review would be appreciated, but we don't need to wait on merges every single time that way.

Sure, I will continue to push commits to this PR.

yangjunhan · 2021-07-30T07:07:12Z

@Airblader I believe this PR is ready for reviews now. BTW, since there is little modifications while bumping from v11 to v12, I have merged those two updates in one commit.

Airblader

Thanks for working on this! Overall it looks great. I left a couple minor comments. There is one main thing we need to do still, however; we need to update the pom.xml to use a compatible node version (12.14.x/14.15.x or later minor version) during a Maven build.

Airblader · 2021-07-30T07:22:18Z

flink-runtime-web/web-dashboard/package.json

-    "zone.js": "~0.8.26"
+    "monaco-editor": "^0.20.0",
+    "ng-zorro-antd": "^12.0.1",
+    "rxjs": "^6.5.3",


This should be >= 6.6 (see https://gist.github.com/LayZeeDK/c822cc812f75bb07b7c55d07ba2719b3)

Airblader · 2021-07-30T07:39:05Z

flink-runtime-web/web-dashboard/package.json

+    "@angular/forms": "~12.1.3",
+    "@angular/platform-browser": "~12.1.3",
+    "@angular/platform-browser-dynamic": "~12.1.3",
+    "@angular/router": "~12.1.3",
    "@antv/g2": "^3.4.10",
    "core-js": "^2.5.4",
    "d3": "^5.9.1",
    "d3-flame-graph": "^4.0.6",
    "d3-tip": "^0.9.1",
    "dagre": "^0.8.4",


We should add dagre to allowedCommonJsDependencies in angular.json to avoid a warning.

…ependencies

Airblader

Thanks! Let's wait for the CI, but LGTM now.

yangjunhan · 2021-08-02T07:12:15Z

@Airblader I believe the CI has finished. Once this PR is merged, I can start working on the eslint migration.

Airblader · 2021-08-02T07:31:55Z

Sounds great. Do you have someone who can merge this PR for you? Otherwise I can find someone who can take care of it.

yangjunhan · 2021-08-02T07:56:25Z

Sounds great. Do you have someone who can merge this PR for you? Otherwise I can find someone who can take care of it.

Please do so. I have no one to do it for me currently.

Airblader · 2021-08-02T07:58:02Z

That's fine. We'll take care of it.

twalthr

Thanks for improving the web UI @yangjunhan. I can help merging this but have to rely on @Airblader judgement for a review. One thing that we should check though is whether we need to update NOTICE files. I see flink-runtime-web/src/main/resources/META-INF/NOTICE maybe also in flink-dist?

yangjunhan · 2021-08-09T02:03:11Z

Hi, @Airblader @twalthr. How is the reviewing going? Could you kindly confirm whether I need to update the NOTICE file as well?

Airblader · 2021-08-09T05:27:08Z

@yangjunhan Yes, the NOTICE file @twalthr mentioned needs to be updated as well.

yangjunhan · 2021-08-09T09:02:11Z

@yangjunhan Yes, the NOTICE file @twalthr mentioned needs to be updated as well.

Okay, I will handle it @Airblader . However, I am not very sure the tool and exact steps to auto-update the NOTICE file, and I do not think that I should manually update the file 😂.

BTW, would it be possible to invite me to the Veverica Slack workspace so that we can communicate there in a more convenient way? I am currently a team member of VVP Front-end in Hangzhou, China.

Airblader · 2021-08-09T09:41:43Z

I actually think the NOTICE files are maintained manually (unfortunately). There is a license checker to verify some basic things, but I am not sure it even runs for the npm dependencies.

I'll try to ask someone about Slack and will get back to you.

Airblader · 2021-08-09T13:35:30Z

@yangjunhan Can you give us your email address with which to invite you to Slack?

…modernization

yangjunhan · 2021-08-10T03:41:46Z

@yangjunhan Can you give us your email address with which to invite you to Slack?

My email address: yangjunhan1234@gmail.com. Thanks.

Airblader · 2021-08-11T07:19:21Z

supersedes #14960

…untime-web-bump-8

twalthr

LGTM

…ndencies, and NOTICE This closes apache#16603.

rmetzger added the review=description? label Jul 27, 2021

yangjunhan changed the title ~~[FLINK-23110][runtime-web] Bump angular's and ng-zorro's version to 8~~ [FLINK-23111][runtime-web] Bump angular's and ng-zorro's version to 8 Jul 27, 2021

[FLINK-23111][runtime-web] Bump angular's and ng-zorro's version to 8

10e6627

yangjunhan force-pushed the build/runtime-web-bump-8 branch from afabfeb to 10e6627 Compare July 27, 2021 08:26

Airblader approved these changes Jul 27, 2021

View reviewed changes

rmetzger added the component=Runtime/WebFrontend label Jul 27, 2021

子扬 added 3 commits July 28, 2021 15:14

[FLINK-23111][runtime-web] Bump angular's and ng-zorro's version to 9

d47fa62

[FLINK-23111][runtime-web] Bump angular's and ng-zorro's version to 10

4b07847

[FLINK-23111][runtime-web] Bump angular's and ng-zorro's version to 12

77f2045

yangjunhan changed the title ~~[FLINK-23111][runtime-web] Bump angular's and ng-zorro's version to 8~~ [FLINK-23111][runtime-web] Bump angular's and ng-zorro's version to 12 Jul 30, 2021

Airblader requested changes Jul 30, 2021

View reviewed changes

[FLINK-23111][runtime-web] Fix maven build node version and several d…

a26f2ff

…ependencies

yangjunhan force-pushed the build/runtime-web-bump-8 branch from 779a268 to a26f2ff Compare July 30, 2021 08:51

Airblader approved these changes Jul 30, 2021

View reviewed changes

twalthr reviewed Aug 5, 2021

View reviewed changes

[FLINK-23111][runtime-web] Update NOTICE file for this web-dashboard …

2d80430

…modernization

Airblader mentioned this pull request Aug 11, 2021

fix scrolling issue in Firefox #14960

Closed

Merge branch 'master' of https://github.com/apache/flink into build/r…

63a1ff7

…untime-web-bump-8

twalthr approved these changes Aug 16, 2021

View reviewed changes

twalthr pushed a commit to twalthr/flink that referenced this pull request Aug 16, 2021

[FLINK-23111][runtime-web] Fix maven build node version, several depe…

2cb623f

…ndencies, and NOTICE This closes apache#16603.

twalthr closed this in 6451a1f Aug 16, 2021

hhkkxxx133 pushed a commit to hhkkxxx133/flink that referenced this pull request Aug 25, 2021

[FLINK-23111][runtime-web] Fix maven build node version, several depe…

1a1d0b0

…ndencies, and NOTICE This closes apache#16603.

yangjunhan deleted the build/runtime-web-bump-8 branch November 1, 2021 09:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FLINK-23111][runtime-web] Bump angular's and ng-zorro's version to 12 #16603

[FLINK-23111][runtime-web] Bump angular's and ng-zorro's version to 12 #16603

yangjunhan commented Jul 27, 2021 •

edited

Loading

flinkbot commented Jul 27, 2021

Airblader left a comment

flinkbot commented Jul 27, 2021 •

edited

Loading

Airblader commented Jul 27, 2021

yangjunhan commented Jul 28, 2021

yangjunhan commented Jul 30, 2021

Airblader left a comment •

edited

Loading

Airblader Jul 30, 2021

Airblader Jul 30, 2021

Airblader left a comment

yangjunhan commented Aug 2, 2021

Airblader commented Aug 2, 2021

yangjunhan commented Aug 2, 2021

Airblader commented Aug 2, 2021

twalthr left a comment

yangjunhan commented Aug 9, 2021

Airblader commented Aug 9, 2021

yangjunhan commented Aug 9, 2021

Airblader commented Aug 9, 2021

Airblader commented Aug 9, 2021

yangjunhan commented Aug 10, 2021

Airblader commented Aug 11, 2021

twalthr left a comment

[FLINK-23111][runtime-web] Bump angular's and ng-zorro's version to 12 #16603

[FLINK-23111][runtime-web] Bump angular's and ng-zorro's version to 12 #16603

Conversation

yangjunhan commented Jul 27, 2021 • edited Loading

What is the purpose of the change

Brief change log

Verifying this change

Does this pull request potentially affect one of the following parts:

Documentation

flinkbot commented Jul 27, 2021

Automated Checks

Review Progress

Airblader left a comment

Choose a reason for hiding this comment

flinkbot commented Jul 27, 2021 • edited Loading

CI report:

Airblader commented Jul 27, 2021

yangjunhan commented Jul 28, 2021

yangjunhan commented Jul 30, 2021

Airblader left a comment • edited Loading

Choose a reason for hiding this comment

Airblader Jul 30, 2021

Choose a reason for hiding this comment

Airblader Jul 30, 2021

Choose a reason for hiding this comment

Airblader left a comment

Choose a reason for hiding this comment

yangjunhan commented Aug 2, 2021

Airblader commented Aug 2, 2021

yangjunhan commented Aug 2, 2021

Airblader commented Aug 2, 2021

twalthr left a comment

Choose a reason for hiding this comment

yangjunhan commented Aug 9, 2021

Airblader commented Aug 9, 2021

yangjunhan commented Aug 9, 2021

Airblader commented Aug 9, 2021

Airblader commented Aug 9, 2021

yangjunhan commented Aug 10, 2021

Airblader commented Aug 11, 2021

twalthr left a comment

Choose a reason for hiding this comment

yangjunhan commented Jul 27, 2021 •

edited

Loading

flinkbot commented Jul 27, 2021 •

edited

Loading

Airblader left a comment •

edited

Loading