Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix][connector-jdbc] Fix a method name typo in postgres unit test. #16635

Merged
merged 1 commit into from
Dec 29, 2021

Conversation

a49a
Copy link
Contributor

@a49a a49a commented Jul 29, 2021

What is the purpose of the change

fix a method name typo in postgres unit test.

Brief change log

  • change tesArrayDataTypes to testArrayDataTypes in PostgresCatalogTest class

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 8519888 (Thu Jul 29 09:50:37 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 29, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@a49a
Copy link
Contributor Author

a49a commented Nov 26, 2021

@snuyanzin please review it

@snuyanzin
Copy link
Contributor

LGTM

@a49a
Copy link
Contributor Author

a49a commented Dec 9, 2021

@leonardBang please review and merge it, thanks.

@a49a
Copy link
Contributor Author

a49a commented Dec 10, 2021

@MartijnVisser please review it.

Copy link
Contributor

@MartijnVisser MartijnVisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deadwind4 Thank you for your contribution. Please don't ping multiple people. It can be quite annoying for people who are working on open source contributions and can actually cause people to ignore these type of pings. As you can see (based on the number of open PRs), there are a lot of open items that need attention. Everyone tries their best to get as much contributions in as possible.

The better the PR is, the higher chance it can be merged quickly. In this case, the PR is not completely following the PR guidelines (as can be found on https://flink.apache.org/contributing/reviewing-prs.html) and the commit message could also be better to meet the Code Style & Quality Guidelines, which can be found at https://flink.apache.org/contributing/code-style-and-quality-preamble.html.

From a priority perspective, this PR addresses a typo in a test, which is not the highest priority for a fix since the impact for users is rather limited.

@a49a a49a changed the title [hotfix][connector-jdbc] fix postgres unit test typo [hotfix][connector-jdbc] fix a method name typo in postgres unit test. Dec 23, 2021
@MartijnVisser
Copy link
Contributor

@deadwind4 Can you also update your commit message?

@a49a
Copy link
Contributor Author

a49a commented Dec 24, 2021

I have updated commit message.

@a49a a49a changed the title [hotfix][connector-jdbc] fix a method name typo in postgres unit test. [hotfix][connector-jdbc] Fix a method name typo in postgres unit test. Dec 24, 2021
@MartijnVisser
Copy link
Contributor

@flinkbot run azure

@MartijnVisser
Copy link
Contributor

MartijnVisser commented Dec 27, 2021

@deadwind4 Can you please rebase your local branch on master ?

@a49a
Copy link
Contributor Author

a49a commented Dec 27, 2021

@MartijnVisser I have rebased on master. Merry Christmas.

@MartijnVisser
Copy link
Contributor

@flinkbot run azure

1 similar comment
@MartijnVisser
Copy link
Contributor

@flinkbot run azure

Copy link
Contributor

@MartijnVisser MartijnVisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @fapaul can you please merge it?

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @MartijnVisser @deadwind4

@leonardBang leonardBang merged commit 9f49f10 into apache:master Dec 29, 2021
@MartijnVisser
Copy link
Contributor

Thanks @leonardBang

niklassemmler pushed a commit to niklassemmler/flink that referenced this pull request Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants