-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hotfix][connector-jdbc] Fix a method name typo in postgres unit test. #16635
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 8519888 (Thu Jul 29 09:50:37 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
@snuyanzin please review it |
LGTM |
@leonardBang please review and merge it, thanks. |
@MartijnVisser please review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deadwind4 Thank you for your contribution. Please don't ping multiple people. It can be quite annoying for people who are working on open source contributions and can actually cause people to ignore these type of pings. As you can see (based on the number of open PRs), there are a lot of open items that need attention. Everyone tries their best to get as much contributions in as possible.
The better the PR is, the higher chance it can be merged quickly. In this case, the PR is not completely following the PR guidelines (as can be found on https://flink.apache.org/contributing/reviewing-prs.html) and the commit message could also be better to meet the Code Style & Quality Guidelines, which can be found at https://flink.apache.org/contributing/code-style-and-quality-preamble.html.
From a priority perspective, this PR addresses a typo in a test, which is not the highest priority for a fix since the impact for users is rather limited.
@deadwind4 Can you also update your commit message? |
8519888
to
2e5e6ae
Compare
I have updated commit message. |
2e5e6ae
to
0b154cc
Compare
@flinkbot run azure |
@deadwind4 Can you please rebase your local branch on |
0b154cc
to
1ebbbf8
Compare
@MartijnVisser I have rebased on master. Merry Christmas. |
@flinkbot run azure |
1 similar comment
@flinkbot run azure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @fapaul can you please merge it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @MartijnVisser @deadwind4
Thanks @leonardBang |
What is the purpose of the change
fix a method name typo in postgres unit test.
Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation