Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-24212][kerbernets] fix the problem that kerberos krb5.conf file is mounted as empty directory, not a expected file #17198

Closed
wants to merge 1 commit into from

Conversation

lzshlzsh
Copy link

@lzshlzsh lzshlzsh commented Sep 8, 2021

What is the purpose of the change

If the user-provided krb5 conf file is not named krb5.conf (e.g named mykrb5.conf),the mount path /etc/krb5.conf in pod will be an empty directory, not a file that we expect.

Brief change log

  • KerberosMountDecorator#decorateFlinkPod

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: Kubernetes deployment
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not documented

@lzshlzsh lzshlzsh changed the title fix the problem that kerberos krb5.conf file is mounted as empty dire… [FLINK-24212][kerbernets] fix the problem that kerberos krb5.conf file is mounted as empty directory, not a expected file Sep 8, 2021
@flinkbot
Copy link
Collaborator

flinkbot commented Sep 8, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 0cf21dd (Wed Sep 08 12:28:35 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 8, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@KarmaGYZ
Copy link
Contributor

KarmaGYZ commented Sep 9, 2021

Thanks for the contribution @lzshlzsh . Your fix looks good. Have you verified it in your local env? Also, it would be good to add a test for it.

@lzshlzsh
Copy link
Author

Thanks for the contribution @lzshlzsh . Your fix looks good. Have you verified it in your local env? Also, it would be good to add a test for it.

Yes, I have verified it in my company production env.
Thanks for your advise, i will add a test for it,

@lzshlzsh
Copy link
Author

Thanks for the contribution @lzshlzsh . Your fix looks good. Have you verified it in your local env? Also, it would be good to add a test for it.

@KarmaGYZ I have added a test for it. Could you help review the code ?

Copy link
Contributor

@KarmaGYZ KarmaGYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, @lzshlzsh . It LGTM except for some minor comments. Also, please squash your two commits and add the prefix "[FLINK-24212][k8s]" to your commit message.

@lzshlzsh lzshlzsh force-pushed the FLINK-24212 branch 2 times, most recently from 39d9b35 to fe3037b Compare September 13, 2021 03:47
Copy link
Contributor

@KarmaGYZ KarmaGYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to merge it once CI is green. @xintongsong Would you like to take another look and help to merge it?

@lzshlzsh
Copy link
Author

@flinkbot run travis
@flinkbot run azure

…nted as empty directory, not the expected file
xintongsong pushed a commit that referenced this pull request Sep 14, 2021
…nted as empty directory, not the expected file

This closes #17198
jianyun8023 pushed a commit to streamnative/flink that referenced this pull request Sep 22, 2021
…nted as empty directory, not the expected file

This closes apache#17198
niklassemmler pushed a commit to niklassemmler/flink that referenced this pull request Feb 3, 2022
…nted as empty directory, not the expected file

This closes apache#17198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants