[FLINK-17914][hs] Keep archives if listStatus fails

[zentol]

Fixes an issue where the HistoryServer was wiping archives if the listing of archives failed (e.g., due to a concurrent deletion of an archive).
This could result in all locally cached archived being deleted.

If this occurs now we keep all archives and defer judgement to the next fetch attempt.

This PR does not add a test because it is difficult to replicate.

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 98aa685 (Mon Oct 04 11:57:57 UTC 2021)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[flinkbot]

CI report:

• 13188c0 Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run azure re-run the last Azure build

[tillrohrmann]

Thanks for creating this PR @zentol. The changes look good to me. One way for testing this change is to write a probabilistic test. You could make the HistoryServerArchiveFetcher.run() callable from the outside. Then you run it once. Then you run it again with a concurrent deletion. Then we could assert that not all entries in the refresh directory have been deleted.