Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-25831] Retrieve the latest non-null prior property from ExecutionVertex #18526

Merged
merged 5 commits into from
Jan 27, 2022
Merged

[FLINK-25831] Retrieve the latest non-null prior property from ExecutionVertex #18526

merged 5 commits into from
Jan 27, 2022

Conversation

tillrohrmann
Copy link
Contributor

What is the purpose of the change

In order to not lose information about prior Executions, this commit iterates over all
prior executions in the ExecutionVertex in order to find the first non-null prior location
and allocation.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 26, 2022 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 53af153 (Wed Jan 26 22:55:53 UTC 2022)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

dmvk
dmvk reviewed Jan 27, 2022
View reviewed changes
Copy link
Member

@dmvk dmvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR Till, LGTM overall 👍 I've added few comments, please take a look

...runtime/src/main/java/org/apache/flink/runtime/scheduler/ExecutionSlotAllocationContext.java Outdated Show resolved Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionVertex.java
* @return Optional containing the latest property if it exists; otherwise {@code
* Optional.empty()}.
*/
private <T> Optional<T> getLatestPriorProperty(Function<ArchivedExecution, T> extractor) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wondering, body of the this method used to be synchronized, is it safe to remove that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The ExecutionGraph used to be thread safe but not it is only driven by a single thread. This made many things a lot easier.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the synchronization from other places as well then? eg. ExecutionVertex#getPriorExecutionAttempt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually, we should remove it, yes.

flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionVertex.java Show resolved Hide resolved
@tillrohrmann
Copy link
Contributor Author

Thanks for the review @dmvk. I've addressed your comments and pushed a rebased update. PTAL.

dmvk
dmvk approved these changes Jan 27, 2022
View reviewed changes
Copy link
Member

@dmvk dmvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, thanks for the update

@tillrohrmann
Copy link
Contributor Author

Thanks for the review @dmvk. Merging this PR now.

@tillrohrmann
[hotfix] Expose EvictingBoundedList.isDroppedIndex
8078091 
This commit exposes the EvictingBoundedList.isDroppedIndex method to allow for checks
whether an element in the list has already been dropped.
@tillrohrmann
[hotfix] Fix checkstyle violations in EvictingBoundedList
4a53970
@tillrohrmann
[hotfix] Replace Hamcrest assertThat with assertj assertThat in Execu…
b89a31f 
…tionVertexTest
@tillrohrmann
[FLINK-25831] Retrieve the latest non-null prior property from Execut…
da29180 
…ionVertex

In order to not lose information about prior Executions, this commit iterates over all
prior executions in the ExecutionVertex in order to find the first non-null prior location
and allocation.

This closes apache#18526.
@tillrohrmann
[hotfix] Remove unused ExecutionVertex.LOG
f7cf926
@tillrohrmann tillrohrmann merged commit f7cf926 into apache:master Jan 27, 2022
@tillrohrmann tillrohrmann deleted the FLINK-25831 branch January 27, 2022 15:46
niklassemmler pushed a commit to niklassemmler/flink that referenced this pull request Feb 3, 2022
@tillrohrmann @niklassemmler
[FLINK-25831] Retrieve the latest non-null prior property from Execut…
cbb4b0c 
…ionVertex

In order to not lose information about prior Executions, this commit iterates over all
prior executions in the ExecutionVertex in order to find the first non-null prior location
and allocation.

This closes apache#18526.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmvk dmvk dmvk approved these changes

Assignees
No one assigned
Labels
component=Runtime/Coordination
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tillrohrmann @flinkbot @dmvk @rmetzger