-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-25243][k8s] Increase the k8s transactional operation max retries in the integration tests #18891
Conversation
…es in the integration tests to make the tests more stable This closes apache#18891.
ff94ce7
to
4a1e6f2
Compare
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 4a1e6f2 (Wed Feb 23 02:18:24 UTC 2022) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
@flinkbot run azure |
…es in the integration tests to make the tests more stable This closes apache#18891.
4a1e6f2
to
59ac7f0
Compare
cc @gaoyunhaii Would you like to have a look on this simple change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @wangyang0918 for the PR!
…es in the integration tests to make the tests more stable This closes apache#18891.
…es in the integration tests to make the tests more stable This closes apache#18891.
What is the purpose of the change
The test in FLINK-25243 failed because of ConfigMap update conflicts. I think we could increase the retry attempt for the testing.
This is not a major issue in production since we are not updating the HA ConfigMaps concurrently so frequently.
Brief change log
Verifying this change
Fabric8FlinkKubeClientITCase
successfully with more than 1000 times. Before this, the test will fail within 50 times.Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation