Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-25243][k8s] Increase the k8s transactional operation max retries in the integration tests #18891

Closed
wants to merge 1 commit into from

Conversation

wangyang0918
Copy link
Contributor

What is the purpose of the change

The test in FLINK-25243 failed because of ConfigMap update conflicts. I think we could increase the retry attempt for the testing.

This is not a major issue in production since we are not updating the HA ConfigMaps concurrently so frequently.

Brief change log

  • Increase the k8s transactional operation max retries in the integration tests

Verifying this change

  • Manually run test Fabric8FlinkKubeClientITCase successfully with more than 1000 times. Before this, the test will fail within 50 times.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

wangyang0918 added a commit to wangyang0918/flink that referenced this pull request Feb 23, 2022
…es in the integration tests to make the tests more stable

This closes apache#18891.
@flinkbot
Copy link
Collaborator

flinkbot commented Feb 23, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 4a1e6f2 (Wed Feb 23 02:18:24 UTC 2022)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@wangyang0918
Copy link
Contributor Author

@flinkbot run azure

…es in the integration tests to make the tests more stable

This closes apache#18891.
@wangyang0918
Copy link
Contributor Author

cc @gaoyunhaii Would you like to have a look on this simple change?

Copy link
Contributor

@gaoyunhaii gaoyunhaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @wangyang0918 for the PR!

@gaoyunhaii gaoyunhaii closed this in 152ad4f Mar 2, 2022
JasonLeeCoding pushed a commit to JasonLeeCoding/flink that referenced this pull request May 27, 2022
…es in the integration tests to make the tests more stable

This closes apache#18891.
zstraw pushed a commit to zstraw/flink that referenced this pull request Jul 4, 2022
…es in the integration tests to make the tests more stable

This closes apache#18891.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants