Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-26368] [kafka] Add setProperty method to KafkaSinkBuilder #18933

Merged
merged 2 commits into from
Apr 4, 2022

Conversation

gyfora
Copy link
Contributor

@gyfora gyfora commented Feb 28, 2022

What is the purpose of the change

Introduce setProperty method to KafkaSinkBuilder to align it with source builder.

Brief change log

  • Added setProperty method

Verifying this change

Added KafkaSinkBuilderTest to test new functionality + modified existing tests to cover this

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): No
  • The public API, i.e., is any changed class annotated with @Public(Evolving): Yes
  • The serializers: No
  • The runtime per-record code paths (performance sensitive): No
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: No
  • The S3 file system connector: No

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? javadoc

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 28, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@gyfora
Copy link
Contributor Author

gyfora commented Mar 16, 2022

@flinkbot run azure

1 similar comment
@gyfora
Copy link
Contributor Author

gyfora commented Mar 28, 2022

@flinkbot run azure

@gyfora
Copy link
Contributor Author

gyfora commented Apr 4, 2022

@morhidi could you please review?

@morhidi
Copy link

morhidi commented Apr 4, 2022

@morhidi could you please review?

sure, I'll have a look at it later today!

@morhidi
Copy link

morhidi commented Apr 4, 2022

+1 LGTM, way more elegant than it was before, thanks for contributing !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants