-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-25771][connectors][Cassandra][tests][flaky] Reduce cassandra testContainer load to avoid timeouts and in general flakiness issues #19059
Conversation
…AndDropTables because it is no more relevant as the table names are now dynamic
.../src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java
Outdated
Show resolved
Hide resolved
…updates the tableID and it is called even in case or retrials. So, we need to drop only the created table for this test (with the related tableID)
…tRetrialAndDropTables because it is no more relevant as the table names are now dynamic" This reverts commit b9eda68.
654cf22
to
66a3a80
Compare
@zentol, I analyzed the problem. Finally I put I did 10 local runs of the whole CassandraITCase with no error. |
@zentol Actually, |
CREATE_TABLE_QUERY.replace(TABLE_NAME_VARIABLE, TABLE_NAME_PREFIX + "initial")); | ||
/* | ||
session.execute( | ||
CREATE_TABLE_QUERY.replace(TABLE_NAME_VARIABLE, TABLE_NAME_PREFIX + "initial")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can just remove it, no need for a comment. I don't remember why we had this in the first place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that is what I already did in the latest commits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no you didn't, its still there :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, my bad. Done
.../src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java
Outdated
Show resolved
Hide resolved
@flinkbot run azure |
@zentol I addressed all your comments. It should be ok now. PTAL |
thanks @zentol for reviewing and merging ! |
I took a look at the history of flaky test and found that:
testCassandraBatchTupleFormat failure https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=32816&view=results
testCassandraScalaTuplePartialColumnUpdate failure https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=32571&view=resultstestCassandraScalaTuplePartialColumnUpdate
testCassandraTableSink failure https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=32272
They fail because the keyspace does not exist while executing create table (in before) whereas the keyspace is created in before class. My guess it that drop tables (in after) is not atomic and drops the keyspace in between. Hence my commit for making it atomic.
The other failures I see are timeouts in only
testRetrialAndDropTables
method. But this test is no more relevant as the table names are now dynamic. Simply remove this testR: @XComp