Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-27682][tests] Migrate ComparatorTestBase to JUnit5 #19766

Merged
merged 1 commit into from
May 19, 2022

Conversation

snuyanzin
Copy link
Contributor

What is the purpose of the change

Update the ComparatorTestBase class and its successors to AssertJ and JUnit 5 following the JUnit 5 Migration Guide

Brief change log

Use JUnit5 and AssertJ in tests instead of JUnit4 and Hamcrest

Verifying this change

This change is a code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: ( no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented May 18, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@zentol zentol self-assigned this May 18, 2022
@zentol zentol merged commit df30751 into apache:master May 19, 2022
@snuyanzin snuyanzin deleted the flink27682 branch May 25, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants