[FLINK-3893] improve LeaderChangeStateCleanupTest #2009
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -61,8 +61,6 @@ public void stop() throws Exception { | |||
| public void notifyListener(String address, UUID leaderSessionID) { | |||
| if (listener != null) { | |||
| listener.notifyLeaderAddress(address, leaderSessionID); | |||
| } else { | |||
| throw new IllegalStateException("The retrieval service has not been started properly."); | |||
There was a problem hiding this comment.
the commit name doesn't seem to properly reflect the change made; it should be "don't fail if retrieval service has not been started"
There was a problem hiding this comment.
Good catch! Fixing that.
mbode
pushed a commit
to mbode/flink
that referenced
this pull request
May 27, 2016
- increase timeout for task managers to be registered - don't fail if leader retrieval service has not been started yet This closes apache#2009
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes discovered in the course of #1978.