Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-2673] [type system] Add a comparator for Scala Option type #2017

Closed
wants to merge 1 commit into from

Conversation

chiwanpark
Copy link
Member

@chiwanpark chiwanpark commented May 22, 2016

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

  • General
    • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
    • The pull request addresses only one issue
    • Each commit in the PR has a meaningful commit message (including the JIRA id)
  • Documentation
    • Documentation has been added for new functionality
    • Old documentation affected by the pull request has been updated
    • JavaDoc for public methods has been added
  • Tests & Build
    • Functionality added by the pull request is covered by tests
    • mvn clean verify has been executed successfully locally or a Travis build has passed

I've added OptionTypeComparator implementation, unit test cases based on ComparatorTestBase and a simple integration test case in JoinITCase. I followed Till's opinion about order between None and Some values.

@chiwanpark
Copy link
Member Author

Failing Travis is not related to this PR.

@StephanEwen
Copy link
Contributor

Thanks, @chiwanpark - looks good to me!

@chiwanpark
Copy link
Member Author

Thanks for review @StephanEwen! Merging...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants