-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-28198][connectors][cassandra] raise driver timeouts per session request and raise it higher than cluster side timetouts #20184
Conversation
ResultSet result = | ||
session.execute( | ||
new SimpleStatement(injectTableName(SELECT_DATA_QUERY)) | ||
.setReadTimeoutMillis(READ_TIMEOUT_MILLIS)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this already set in the cluster builder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but as I wrote in the ticket:
"the driver timeouts were set on the clusterBuilder because previous timeout errors were only on test cases. Here, the request timeouts are on session.execute that do not use the ClusterBuilder. Thus, they use the default 12s timeout. I'll raise to 36s per session request."
the ClusterBuilder
is only used for Sinks, InputFormats, OutputFormats, etc... but not for session.execute
requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zentol there has been several of these timeout issues that make the build flaky. @MartijnVisser pinged me to quickly solve this issue. Tell me if you need anything more on this PR.
4244419
to
24ae7bd
Compare
@flinkbot run azure |
1 similar comment
@flinkbot run azure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@echauchot Thanks for the PR. Let's get this merged :)
…n request and raise it higher than cluster side timetouts (apache#20184) * [FLINK-28198][connectors][cassandra] Raise driver timeouts per session request and raise it higher than cluster side timeouts. This closes apache#20184
…n request and raise it higher than cluster side timetouts (apache#20184) * [FLINK-28198][connectors][cassandra] Raise driver timeouts per session request and raise it higher than cluster side timeouts. This closes apache#20184
…n request and raise it higher than cluster side timetouts (apache#20184) * [FLINK-28198][connectors][cassandra] Raise driver timeouts per session request and raise it higher than cluster side timeouts. This closes apache#20184
Contribution Checklist
What is the purpose of the change
Raise driver timeouts per session request and raise it higher than cluster side timetouts
Brief change log
Change in the CassandraITCase
Verifying this change
This change is already covered by existing tests, such as CassandraITCase
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation
R: @MartijnVisser