Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-28589][runtime-web] enhance web UI for speculative execution #20380

Closed
wants to merge 5 commits into from

Conversation

yangjunhan
Copy link
Contributor

What is the purpose of the change

As a follow-up step of FLIP-168 and FLIP-224, the Flink Web UI now needs to be enhanced to display the related information if the speculative execution mechanism is enabled. This PR enhances the web UI for the newly adopted API changes.

Brief change log

  • show blocked free slots and blocked TM in overview
  • show blocked badge in TM list and detail pages
  • enable expanded rows of other concurrent attempts for subtasks
  • others: replace loading icon with text to avoid spin animation bottleneck

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@yangjunhan
Copy link
Contributor Author

Hi, @simplejason. Could you help me review this PR which only concerns web UI changes?

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 27, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just left some comments about code style, it's not a block to this PR :) Thanks for your efforts for this 👍

@yangjunhan
Copy link
Contributor Author

@simplejason Thanks for the advice. All mentioned above have been taken care of.

@yangjunhan
Copy link
Contributor Author

@flinkbot run azure

@zhuzhurk
Copy link
Contributor

zhuzhurk commented Aug 2, 2022

@flinkbot run azure

Copy link
Contributor

@zhuzhurk zhuzhurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR! @yangjunhan
We have verified the change locally along with speculative execution and it looks good.

@zhuzhurk
Copy link
Contributor

zhuzhurk commented Aug 2, 2022

Merging.

@zhuzhurk zhuzhurk closed this in f6c5dc1 Aug 2, 2022
huangxiaofeng10047 pushed a commit to huangxiaofeng10047/flink that referenced this pull request Nov 3, 2022
@yangjunhan yangjunhan deleted the FLINK-28589 branch January 4, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants