-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-28589][runtime-web] enhance web UI for speculative execution #20380
Conversation
Hi, @simplejason. Could you help me review this PR which only concerns web UI changes? |
...oard/src/app/pages/job/overview/backpressure/job-overview-drawer-backpressure.component.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I just left some comments about code style, it's not a block to this PR :) Thanks for your efforts for this 👍
...runtime-web/web-dashboard/src/app/pages/overview/statistic/overview-statistic.component.less
Outdated
Show resolved
Hide resolved
@simplejason Thanks for the advice. All mentioned above have been taken care of. |
@flinkbot run azure |
…ttempts for subtasks
…imation bottleneck
@flinkbot run azure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this PR! @yangjunhan
We have verified the change locally along with speculative execution and it looks good.
Merging. |
…ttempts for subtasks This closes apache#20380.
What is the purpose of the change
As a follow-up step of FLIP-168 and FLIP-224, the Flink Web UI now needs to be enhanced to display the related information if the speculative execution mechanism is enabled. This PR enhances the web UI for the newly adopted API changes.
Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation